Re: Windows fixes for sockpfaf

2006-07-06 Thread Simon Josefsson
Eric Blake <[EMAIL PROTECTED]> writes: > Both patches installed, as proposed. Thanks! >> However, I'm not sure this is the Right Thing. Why doesn't it work to >> include winsock2.h under cygwin? I.e., what's in your config.log when >> the above happen? > > On cygwin, you have a choice for sock

Re: Windows fixes for sockpfaf

2006-07-05 Thread Eric Blake
Simon Josefsson extundo.com> writes: > > There is a potential problem here, if sockpfaf is ever used without > the sys_socket, but there is no such module today. Maybe the > sockpfaf.m4 file should be moved into the sys_socket module? As long as the dependency is satisfied, with gl_HEADER_SYS_

Re: Windows fixes for sockpfaf

2006-07-05 Thread Simon Josefsson
Eric Blake <[EMAIL PROTECTED]> writes: > Simon Josefsson extundo.com> writes: > >> >> This patch makes sockpfaf define HAVE_IPV? properly when >> cross-compiling to mingw32. (For reference, IPv4 is detected, but not >> IPv6.) > > And it broke compilation on cygwin, where you should use POSIX he

Re: Windows fixes for sockpfaf

2006-07-05 Thread Simon Josefsson
Eric Blake <[EMAIL PROTECTED]> writes: > Eric Blake byu.net> writes: > >> $ gnulib-tool --test getaddrinfo >> ... >> gcc -DHAVE_CONFIG_H -I. -I../../lib -I.. -Wall -O2 - >> c ../../lib/getaddrinfo.c >> ../../lib/getaddrinfo.c: In function `getnameinfo': >> ../../lib/getaddrinfo.c:324: error:

Re: Windows fixes for sockpfaf

2006-07-05 Thread Eric Blake
Eric Blake byu.net> writes: > $ gnulib-tool --test getaddrinfo > ... > gcc -DHAVE_CONFIG_H -I. -I../../lib -I.. -Wall -O2 - > c ../../lib/getaddrinfo.c > ../../lib/getaddrinfo.c: In function `getnameinfo': > ../../lib/getaddrinfo.c:324: error: `NI_NUMERICHOST' undeclared (first use in > this

Re: Windows fixes for sockpfaf

2006-07-05 Thread Eric Blake
Simon Josefsson extundo.com> writes: > > This patch makes sockpfaf define HAVE_IPV? properly when > cross-compiling to mingw32. (For reference, IPv4 is detected, but not > IPv6.) And it broke compilation on cygwin, where you should use POSIX headers instead of sucking in Windows headers and g

Re: Windows fixes for sockpfaf

2006-06-22 Thread Simon Josefsson
Bruno Haible <[EMAIL PROTECTED]> writes: > Simon, > >> Ok to install the patch? You're mentioned as the origin of the file. > > Sure. You don't need to ask me: I'm not mentioned as maintainer of this > file in modules/*. Done. The M4 macro doesn't seem to belong to one canonical module, so I wa

Re: Windows fixes for sockpfaf

2006-06-22 Thread Bruno Haible
Simon, > Ok to install the patch? You're mentioned as the origin of the file. Sure. You don't need to ask me: I'm not mentioned as maintainer of this file in modules/*. Bruno

Re: Windows fixes for sockpfaf

2006-06-22 Thread Simon Josefsson
Bruno Haible <[EMAIL PROTECTED]> writes: > Simon Josefsson wrote: >> I'd admit that these winsock2.h tests are a bit ugly, but I don't see >> a good alternative. Ideas? > > I don't see a better alternative. The problem is that the replacement > is not available at the moment the autoconf test is

Re: Windows fixes for sockpfaf

2006-06-22 Thread Bruno Haible
Simon Josefsson wrote: > I'd admit that these winsock2.h tests are a bit ugly, but I don't see > a good alternative. Ideas? I don't see a better alternative. The problem is that the replacement is not available at the moment the autoconf test is run. We cannot change that easily. Bruno

Windows fixes for sockpfaf

2006-06-21 Thread Simon Josefsson
This patch makes sockpfaf define HAVE_IPV? properly when cross-compiling to mingw32. (For reference, IPv4 is detected, but not IPv6.) I'd admit that these winsock2.h tests are a bit ugly, but I don't see a good alternative. Ideas? --- sockpfaf.m4 16 Jun 2006 17:36:05 +0200 1.2 +++ sockpfaf