Re: The non-recursive-gnulib-prefix-hack module

On Wed, Feb 1, 2017 at 2:28 PM, John W. Eaton wrote: > Is there anything I can do to help get this change accepted as part of > gnulib? > > I'd really like to be able to use a completely non-recursive Makefile for > Octave. Hi John, A great step in the right direction would be to ensure that your

Re: The non-recursive-gnulib-prefix-hack module

Is there anything I can do to help get this change accepted as part of gnulib? I'd really like to be able to use a completely non-recursive Makefile for Octave. jwe On 11/28/2016 12:40 AM, John W. Eaton wrote: On 11/27/2016 06:18 PM, Bruno Haible wrote: John, I added AC_CONFIG_LIBOB

Re: The non-recursive-gnulib-prefix-hack module

On 11/27/2016 06:18 PM, Bruno Haible wrote: John, I added AC_CONFIG_LIBOBJ_DIR([libgnu]) to my configure.ac file. Maybe gnulib-tool could do this automatically if --non-recursive-makefile is specified? gnulib-tool does not rely on AC_LIBOBJ and friends, because these autoconf macros ass

Re: The non-recursive-gnulib-prefix-hack module

John, > I added > >AC_CONFIG_LIBOBJ_DIR([libgnu]) > > to my configure.ac file. Maybe gnulib-tool could do this automatically > if --non-recursive-makefile is specified? gnulib-tool does not rely on AC_LIBOBJ and friends, because these autoconf macros assume that there is only one lib/ dir

Re: The non-recursive-gnulib-prefix-hack module

On 11/27/2016 05:02 PM, Bruno Haible wrote: * I would add a check to make sure that --non-recursive-makefile is only used together with the --makefile-name option. I cannot see how/why someone would use --non-recursive-makefile without --makefile-name. This simplies some of the logic (e.g.

Re: The non-recursive-gnulib-prefix-hack module

;t realize that. I also completely missed the option initially. Now I'm calling gnulib-tool with the --makefile-name option and my new --non-recursive-makefile option. Instead of using the non-recursive-gnulib-prefix-hack module I added AC_CONFIG_LIBOBJ_DIR([libgnu]) to my configure.

Re: The non-recursive-gnulib-prefix-hack module

Hi John, > I also started working on a change to replace the > non-recursive-gnulib-prefix-hack module with a --non-recursive-makefile > option for gnulib-tool. My initial attempt is attached. Great! A couple of small remarks: * I would add a check to make sure that --non-recursive

Re: The non-recursive-gnulib-prefix-hack module

Hi John, > I did that for Octave and the resulting files are attached. This is great! > The gnulib-generated file is Makefile.am. The edited file that I > included in Octave's main Makefile.am file is module.mk. > ... > Things like AUTOMAKE_OPTIONS need to be omitted. We can assume that the

Re: The non-recursive-gnulib-prefix-hack module

can see how gnulib-tool should be modified. I did that for Octave and the resulting files are attached. I also started working on a change to replace the non-recursive-gnulib-prefix-hack module with a --non-recursive-makefile option for gnulib-tool. My initial attempt is attached. It gets part

Re: The non-recursive-gnulib-prefix-hack module

hich >> looks like it needs to be initialized before gl_source_base is set. > > Yes, the statement > ac_config_libobj_dir=$gl_source_base > is also out of order. > >> I'll need to do a lot more digging to figure all that out. > > It's probably not worth

Re: The non-recursive-gnulib-prefix-hack module

ig_libobj_dir=$gl_source_base is also out of order. > I'll need to do a lot more digging to figure all that out. It's probably not worth to try to fix the non-recursive-gnulib-prefix-hack module in this direction. Please feel free to revert my change to modules/non-recursive-gnulib-prefix-hack, and add a comment why 'lib' has to be hardcoded in this place. Bruno

Re: The non-recursive-gnulib-prefix-hack module

-tool (func_create_testdir): Don't include the >>>> non-recursive-gnulib-prefix-hack module. >>> That looks fine. Thanks again. >> >> OK, I've pushed it. >> >>>> 4) This module was added in September 2012. Does this mean that no one

Re: The non-recursive-gnulib-prefix-hack module

On 22/10/16 18:25, Bruno Haible wrote: > Hi Jim, > >>> 2016-10-16 Bruno Haible >>> >>> gnulib-tool: Make --create-testdir on all modules work again. >>> * gnulib-tool (func_create_testdir): Don't include the >>>

Re: The non-recursive-gnulib-prefix-hack module

Jim Meyering wrote: > I've confirmed that with that, coreutils still bootstraps and passes > "make distcheck". Thank you for the testing, Jim. Pushed. Bruno -- In memoriam Hana Brady

Re: The non-recursive-gnulib-prefix-hack module

On Sat, Oct 22, 2016 at 10:25 AM, Bruno Haible wrote: > This is better now. But still better would be to not hardcode 'lib' at all, > and instead use whatever value was passed to gnulib-tool via --source-base. > Below is a proposed patch. (The variable $gl_source_base is already used in a > simila

Re: The non-recursive-gnulib-prefix-hack module

On Sat, Oct 22, 2016 at 19:25:46 +0200, Bruno Haible wrote: > This is better now. But still better would be to not hardcode 'lib' at all, > and instead use whatever value was passed to gnulib-tool via --source-base. > Below is a proposed patch. (The variable $gl_source_base is already used in a > s

Re: The non-recursive-gnulib-prefix-hack module

Hi Mike, > Hi, I had attempted to get non-recursive-gnulib-prefix-hack working with > Octave (where the gnulib subdirectory is not named 'lib'). I sent a > patch and a query for help to bug-gnulib last year and attracted no > interest, I assume because there are very few users. > > Original (work

Re: The non-recursive-gnulib-prefix-hack module

Hi Jim, > > 2016-10-16 Bruno Haible > > > > gnulib-tool: Make --create-testdir on all modules work again. > > * gnulib-tool (func_create_testdir): Don't include the > > non-recursive-gnulib-prefix-hack module. > That looks fine. Tha

Re: The non-recursive-gnulib-prefix-hack module

dule was added in September 2012. Does this mean that no one has > used >gnulib-tool --create-testdir option to produce a testdir for all modules, >in four years?! Probably true. Recently I tried to do something similar, but got side-tracked. I'm glad you're f

The non-recursive-gnulib-prefix-hack module

uce a testdir for all modules, in four years?! For problem 2), I propose the remedy below. Bruno 2016-10-16 Bruno Haible gnulib-tool: Make --create-testdir on all modules work again. * gnulib-tool (func_create_testdir): Don't include the non-recursive-gnulib-prefix-ha