Re: Support for options in valgrind-tests

2011-03-17 Thread Reuben Thomas
On 17 March 2011 06:27, Ralf Wildenhues wrote: > I suggest you guys check out the parallel-tests driver from recent > Automake.  It provides makefile variables for specifying a command > to run specific tests, plus options to that.  That can be used for > valgrind. It would certainly be nice if t

Re: Support for options in valgrind-tests

2011-03-16 Thread Ralf Wildenhues
I suggest you guys check out the parallel-tests driver from recent Automake. It provides makefile variables for specifying a command to run specific tests, plus options to that. That can be used for valgrind. Quoting the documentation: For tests that match an extension `.EXT' listed in `TEST

Re: Support for options in valgrind-tests

2011-03-16 Thread Reuben Thomas
On 16 March 2011 23:42, Bernd Becker wrote: > Am 16.03.2011 22:52, schrieb Reuben Thomas: >> Sounds like what's needed is a pair of variables that works like >> CPPFLAGS/AM_CPPFLAGS. >> > how about an approach passing a variable into make like > test_a_VALGRIND_OPTIONS=foo make check > then you sa

Re: Support for options in valgrind-tests

2011-03-16 Thread Bernd Becker
Am 16.03.2011 22:52, schrieb Reuben Thomas: > On 16 March 2011 21:22, Bernd Becker wrote: >> Hi Thomas, >> >> Am 12.03.2011 18:41, schrieb Reuben Thomas: >>> Another day, another nice surprise from gnulib: it supports valgrind, >>> so I can remove my own code for that...only, no I can't, because I

Re: Support for options in valgrind-tests

2011-03-16 Thread Reuben Thomas
On 16 March 2011 21:22, Bernd Becker wrote: > Hi Thomas, > > Am 12.03.2011 18:41, schrieb Reuben Thomas: >> Another day, another nice surprise from gnulib: it supports valgrind, >> so I can remove my own code for that...only, no I can't, because I add >> options (I add --error-exitcode=1 --leak-ch

Re: Support for options in valgrind-tests

2011-03-16 Thread Bernd Becker
Hi Thomas, Am 12.03.2011 18:41, schrieb Reuben Thomas: > Another day, another nice surprise from gnulib: it supports valgrind, > so I can remove my own code for that...only, no I can't, because I add > options (I add --error-exitcode=1 --leak-check=full). > > So, two alternative suggestions: > > 1

Support for options in valgrind-tests

2011-03-12 Thread Reuben Thomas
Another day, another nice surprise from gnulib: it supports valgrind, so I can remove my own code for that...only, no I can't, because I add options (I add --error-exitcode=1 --leak-check=full). So, two alternative suggestions: 1. Agree that these options are must-haves (rationale: one's code sho