Re: SCO OpenServer

2024-06-27 Thread Bruno Haible
Tim Rice wrote: > This was more for reference than asking to add for support for OpenServer 5. OK. > > sense, since SCO OpenServer 5 is a museum system, as you can see > > True, old. Glad you acknowledge that. > Just please do not remove any bits related to OpenServe

Re: SCO OpenServer

2024-06-26 Thread Tim Rice
t; > > ... > > > > Still a current product. > > SCO OpenServer 5 is not supported by Gnulib [1]. Not surprising. It's a pain to work with. > Adding support for SCO OpenServer 5 to any Gnulib module would make no This was more for reference than asking to add for supp

Re: SCO OpenServer

2024-06-26 Thread Bruno Haible
Tim Rice wrote: > OpenServer 5 uses 'unsigned short'. > ... > tim@timosr5d 6% egrep 'gid_t|uid_t' /usr/include/sys/types.h > typedef unsigned short uid_t; > typedef unsigned short gid_t; > ... > > Still a current product. SCO OpenServer 5 is not supp

Re: Port getprogname module to SCO OpenServer

2020-10-11 Thread Bruno Haible
Hi Benji, > > It is better, but there are still (minor) things to tweak. > Minor things tweaked. > > I'm not sure why I cast getpid to int. > > Including string.h did fix the strrchr warning. > > Now using __SCO_SERVER__ || __sysv5__ for OpenServer6/UnixWare7 and SCO > cc/GCC detection. Thank

Re: Port getprogname module to SCO OpenServer

2020-10-06 Thread Benji Wiebe
It is better, but there are still (minor) things to tweak. Minor things tweaked. I'm not sure why I cast getpid to int. Including string.h did fix the strrchr warning. Now using __SCO_SERVER__ || __sysv5__ for OpenServer6/UnixWare7 and SCO cc/GCC detection. Also as far as the indentation

Re: Port getprogname module to SCO OpenServer

2020-10-06 Thread Tim Rice
On Wed, 7 Oct 2020, Bruno Haible wrote: > I hope the main conclusions from the table [1] stand? Yes. > Bruno > > [1] https://lists.gnu.org/archive/html/bug-gnulib/2020-10/msg00022.html > -- Tim RiceMultitalents t...@multitalents.net

Re: Port getprogname module to SCO OpenServer

2020-10-06 Thread Bruno Haible
Tim Rice wrote: > > out, namely that *none* of the 6 compilers that he tested defines both > > __USLC__ and __SCO_VERSION__. > > Actually the table *does* show __USLC__ and __SCO_VERSION__ defined > in the native compiler for both Openserver 6 and UnixWare 7. Oops, you are right. Seems I have pro

Re: Port getprogname module to SCO OpenServer

2020-10-06 Thread Tim Rice
On Tue, 6 Oct 2020, Bruno Haible wrote: > Benji Wiebe wrote: > > http://osr600doc.sco.com/en/man/html.CP/cc.CP.html#cc_preassertion > > > > Is where the predefined constants for the builtin cc are listed. > > Thanks. You will notice that this web page says that both __USLC__ and > __SCO_VERSION_

Re: Port getprogname module to SCO OpenServer

2020-10-06 Thread Bruno Haible
Hi Tim, > > OK. And what about __UNIXWARE__ and __OPENSERVER__ that I see being used > > [1]? > > On which versions are they defined? > > For the most part __UNIXWARE__ and __OPENSERVER__ were used by some in > build driver scripts. Usually like CFLAGS="-O -D__UNIXWARE__" Since you say "by some

Re: Port getprogname module to SCO OpenServer

2020-10-06 Thread Bruno Haible
Benji Wiebe wrote: > http://osr600doc.sco.com/en/man/html.CP/cc.CP.html#cc_preassertion > > Is where the predefined constants for the builtin cc are listed. Thanks. You will notice that this web page says that both __USLC__ and __SCO_VERSION__ are defined. Which contradicts what Tim Rice just fou

Re: Port getprogname module to SCO OpenServer

2020-10-05 Thread Tim Rice
constants for the builtin cc are listed. Do we need to > support a possible future port of clang to SCO OpenServer when OpenServer is > dead? > > Or just make it work with the current compilers available? (SCO's cc and GCC) Just make it work for current compilers available. A

Re: Port getprogname module to SCO OpenServer

2020-10-05 Thread Benji Wiebe
http://osr600doc.sco.com/en/man/html.CP/cc.CP.html#cc_preassertion Is where the predefined constants for the builtin cc are listed. Do we need to support a possible future port of clang to SCO OpenServer when OpenServer is dead? Or just make it work with the current compilers available

Re: Port getprogname module to SCO OpenServer

2020-10-05 Thread Tim Rice
On Sun, 4 Oct 2020, Bruno Haible wrote: > OK. And what about __UNIXWARE__ and __OPENSERVER__ that I see being used [1]? > On which versions are they defined? For the most part __UNIXWARE__ and __OPENSERVER__ were used by some in build driver scripts. Usually like CFLAGS="-O -D__UNIXWARE__" As y

Re: Port getprogname module to SCO OpenServer

2020-10-03 Thread Bruno Haible
Tim Rice wrote: > > Hi Bruno, > > On Sat, 3 Oct 2020, Bruno Haible wrote: > > > Tim Rice wrote: > > > > +# elif defined __SCO_VERSION__ /* SCO OpenServer/UnixWare */ > > > > > > While __SCO_VERSION__ covers Openserver 6 and UnixWare 7, >

Re: Port getprogname module to SCO OpenServer

2020-10-03 Thread Tim Rice
Hi Bruno, On Sat, 3 Oct 2020, Bruno Haible wrote: > Tim Rice wrote: > > > +# elif defined __SCO_VERSION__ /* SCO OpenServer/UnixWare */ > > > > While __SCO_VERSION__ covers Openserver 6 and UnixWare 7, > > what is normally used for 6 and 7 is __USLC__ f

Re: Port getprogname module to SCO OpenServer

2020-10-03 Thread Bruno Haible
[Re-adding bug-gnulib back in CC. Please keep bug-gnulib in CC.] Benji Wiebe wrote: > Hey thanks a lot for the feedback Bruno and Tim! My C is sort of rusty > right now. I believe I've addressed all your concerns and suggestions in > the patch below. > > Thanks again! It is better, but there a

Re: Port getprogname module to SCO OpenServer

2020-10-03 Thread Bruno Haible
Tim Rice wrote: > > +# elif defined __SCO_VERSION__ /* SCO OpenServer/UnixWare */ > > While __SCO_VERSION__ covers Openserver 6 and UnixWare 7, > what is normally used for 6 and 7 is __USLC__ for the native compiler > and __sysv5__ for gcc > > Ie. > # elif defined __

Re: Port getprogname module to SCO OpenServer

2020-10-01 Thread Benji Wiebe
Oh and I forgot to mention, the cast from strrchr is needed to silence a warning from SCO's CC: UX:acomp: WARNING: "gpn_test.c", line 16: improper pointer/integer combination: op "="

Re: Port getprogname module to SCO OpenServer

2020-10-01 Thread Tim Rice
Hi Benji, On Wed, 30 Sep 2020, Benji Wiebe wrote: > I ported the getprogname module to SCO OpenServer 6 (should also work on OSR5 > and UnixWare). It prevents several OSS packages from building. No proc filesystem on Openserver 5 so it will not work there. Would need a different "

Re: Port getprogname module to SCO OpenServer

2020-10-01 Thread Bruno Haible
Hi Benji, > I just made it read from /proc//cmdline to get the command name. > The patch is below. Comments are welcome. Thanks! Thanks for the patch. I have a couple of improvement suggestions, though: > + char buf[50]; > + char *ret; > + int fd; > + int pathlen; Can you try to minimize t

Port getprogname module to SCO OpenServer

2020-10-01 Thread Benji Wiebe
I ported the getprogname module to SCO OpenServer 6 (should also work on OSR5 and UnixWare). It prevents several OSS packages from building. I just made it read from /proc//cmdline to get the command name. The patch is below. Comments are welcome. Thanks! -Benji diff --git a/lib