Re: xreadlink: Rewrite as a simple mreadlink wrapper.

2007-09-02 Thread Jim Meyering
Bruno Haible <[EMAIL PROTECTED]> wrote: > Hello Jim, > >> as far as I can see, no one even uses xreadlink any more, so it's not urgent. > > The 'relocatable' facility uses xreadlink. > >> However, your point about the "a" vs. "m" prefix is valid, >> and I've just renamed mreadlink-with-size. > > Th

Re: xreadlink: Rewrite as a simple mreadlink wrapper.

2007-09-02 Thread Bruno Haible
Hello Jim, > as far as I can see, no one even uses xreadlink any more, so it's not urgent. The 'relocatable' facility uses xreadlink. > However, your point about the "a" vs. "m" prefix is valid, > and I've just renamed mreadlink-with-size. Thanks. I've got an 'areadlink' module ready now, but I

Re: xreadlink: Rewrite as a simple mreadlink wrapper.

2007-08-28 Thread Jim Meyering
Bruno Haible <[EMAIL PROTECTED]> wrote: >> I did most of this weeks ago and just noticed I never checked it in. >> Ok with you, Bruno? > > I'll make up my mind on it once you have put an 'mreadlink' module into > gnulib. I don't see such a module in gnulib, nor in coreutils. Remember Ha! Good poi

Re: xreadlink: Rewrite as a simple mreadlink wrapper.

2007-08-26 Thread Bruno Haible
Hi Jim, > I did most of this weeks ago and just noticed I never checked it in. > Ok with you, Bruno? I'll make up my mind on it once you have put an 'mreadlink' module into gnulib. I don't see such a module in gnulib, nor in coreutils. Remember that the difference between xreadlink_with_size and

Re: xreadlink

2007-02-28 Thread Jim Meyering
Bruno Haible <[EMAIL PROTECTED]> wrote: > And here's the accompanying coreutils patch. The call in src/readlink.c > is actually better served with the 1-argument xreadlink(), since memcopying > a small string is typically faster than a memory allocation of 1 KB. > > 2007-02-28 Bruno Haible <[EMA

Re: xreadlink

2007-02-28 Thread Bruno Haible
And here's the accompanying coreutils patch. The call in src/readlink.c is actually better served with the 1-argument xreadlink(), since memcopying a small string is typically faster than a memory allocation of 1 KB. 2007-02-28 Bruno Haible <[EMAIL PROTECTED]> * bootstrap.conf (gnulib_

Re: xreadlink

2007-02-28 Thread Bruno Haible
Jim Meyering wrote: > I like (a), but would prefer a different name, e.g., > xreadlink_with_hint > xreadlink_with_size > xreadlink_size_hint > xreadlink_length_hint > because the hint needn't come from stat/st_size, > > or even just > xreadlink_hint > or, shortest of all ("2", for two pa

Re: xreadlink

2007-02-25 Thread Jim Meyering
Bruno Haible <[EMAIL PROTECTED]> wrote: > What can we do in gnulib? > > (a) Have 2 xreadlink like functions. Since the one without prior stat is more > natural, I would propose to rename the coreutils one, with the 'size' > argument, to 'xreadlink_after_stat'. > > Or > > (b) Merge the two f

Re: xreadlink bug

2005-10-02 Thread Paul Eggert
Ben Pfaff <[EMAIL PROTECTED]> writes: > --- modules/xreadlink 12 Aug 2005 12:21:44 - 1.7 > +++ modules/xreadlink 2 Oct 2005 23:37:04 - > @@ -14,9 +14,6 @@ ssize_t > configure.ac: > gl_XREADLINK > > -Makefile.am: > -lib_SOURCES += xreadlink.h xreadlink.c > - Thanks for reporting t