Eric Blake wrote:
> According to Jim Meyering on 11/22/2009 1:57 AM:
>> Thanks for the patch.
>> How about the following instead?
>> Then, if some package is defining PACKAGE specially
>> and expecting that value to be used here, it will still appear.
>
> I'd say go ahead and commit this.
Done.
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Jim Meyering on 11/22/2009 1:57 AM:
> Thanks for the patch.
> How about the following instead?
> Then, if some package is defining PACKAGE specially
> and expecting that value to be used here, it will still appear.
I'd say go ahead and co
On Sun 22 Nov 2009 09:57, Jim Meyering writes:
> Thanks for the patch.
> How about the following instead?
> Then, if some package is defining PACKAGE specially
> and expecting that value to be used here, it will still appear.
Thanks for the fix. I knew that something wasn't right :)
We'll test
Andy Wingo wrote:
> I just applied this to Guile. Perhaps something like it should go into
> Gnulib?
...
> diff --git a/lib/version-etc.c b/lib/version-etc.c
> index 4f9de48..a7be46e 100644
> --- a/lib/version-etc.c
> +++ b/lib/version-etc.c
> @@ -245,7 +245,7 @@ emit_bug_reporting_address (void)
>
Eric Blake asked:
> Gnulib pre-assumes that you are using Automake, and automake generally
> guarantees that PACKAGE is defined. What is guile doing that violates
> this assumption?
guile's configure.ac is invoking
AM_INIT_AUTOMAKE([... no-define ...])
which has the effect that PACKAGE and VERS
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Andy Wingo on 11/21/2009 10:59 AM:
> Hello,
>
> I just applied this to Guile. Perhaps something like it should go into
> Gnulib?
Gnulib pre-assumes that you are using Automake, and automake generally
guarantees that PACKAGE is defined.
