Re: timevar: small tweaks

2018-09-30 Thread Bruno Haible
Hi Akim, Thanks for the review. > > - It is pointless to omit the parameter names from the function > > declarations > >if the comments talk about TIMEVAR, ELAPSED, FP, etc. > > Here, I don’t understand why you commented the argument names. > It would be clearer with them uncommented. Thi

Re: timevar: small tweaks

2018-09-30 Thread Akim Demaille
Hi Bruno, > Le 30 sept. 2018 à 01:09, Bruno Haible a écrit : > > Hi Akim, > > How about the following patches: > > * In timevar.c: Include timevar.h first. This is a Gnulib best practice, which > has the benefit of verifying that the header file is self-contained. > > * In timevar.def: > -