Re: tempname.c vs. mingw

2006-06-29 Thread Paul Eggert
Eric Blake <[EMAIL PROTECTED]> writes: >> Also, older Unix systems lack >> a mkdir declaration, but have mkdir (it may not fit the prototype, >> though, so you shouldn't declare it without checking). > > Is that even worth bothering with, for modern portability targets? Perhaps not. You're righ

Re: tempname.c vs. mingw

2006-06-29 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Eric Blake on 6/29/2006 4:15 PM: > > Well, it was the suggestion from Bruno as seen in functions.texi, and has the > benefit that &mkdir is still a valid function pointer to the OS's exported > function (with a static replacement functi

Re: tempname.c vs. mingw

2006-06-29 Thread Eric Blake
Paul Eggert CS.UCLA.EDU> writes: > > +#if ! HAVE_DECL_MKDIR > > +# if HAVE_IO_H > > +# include > > +# endif > > +# define mkdir ((int (*)()) _mkdir) > > +#endif > > Surely this won't work if ! HAVE_DECL_MKDIR && ! HAVE_IO_H, since > _mkdir will be undefined in that case. Agreed; and I used yo

Re: tempname.c vs. mingw

2006-06-29 Thread Paul Eggert
Eric Blake <[EMAIL PROTECTED]> writes: > +#if ! HAVE_DECL_MKDIR > +# if HAVE_IO_H > +# include > +# endif > +# define mkdir ((int (*)()) _mkdir) > +#endif Surely this won't work if ! HAVE_DECL_MKDIR && ! HAVE_IO_H, since _mkdir will be undefined in that case. Also, older Unix systems lack a mk

Re: tempname.c vs. mingw

2006-06-29 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Paul Eggert on 6/28/2006 10:32 AM: > > I'd rather not do that. Surely there's a less-intrusive way to fix > this problem on nonstandard platforms like that. You can use your own > replacement, for example. > Here's my proposal for a

Re: tempname.c vs. mingw

2006-06-28 Thread Paul Eggert
Eric Blake <[EMAIL PROTECTED]> writes: > Would it be worth augmenting the mkdir module to add lib/mkdir.h > which neutralizes mingw mkdir, then making all modules which use > mkdir (mkdir-p, openat, mkdtemp, mkstemp) depend on the mkdir module > and include "mkdir.h" so that they can work on ming