Re: socket.h

2006-02-08 Thread Simon Josefsson
Jim Meyering <[EMAIL PROTECTED]> writes: >> I agree. I wish 'indent' could fix this >> too. Maybe it can? Even if I agree many code writing ideas given >> here, I forget them all the time. > > I tend to forget, too, so have automated quite a few policy checks, > over the years. You might try a

Re: socket.h

2006-01-24 Thread Bruno Haible
Paul Eggert wrote: > I don't see any technical reason to prefer the parentheses. While I agree that there are no technical reason to put the parentheses, I wouldn't be religious on the issue, because the majority of the C programmers does it the other way. The same argument as for "const char *":

Re: socket.h

2006-01-24 Thread Jim Meyering
Simon Josefsson <[EMAIL PROTECTED]> wrote: >> Any objection to removing [useless parentheses]? > > No, please install them. Ok. I've checked that in. > I agree. I wish 'indent' could fix this > too. Maybe it can? Even if I agree many code writing ideas given > here, I forget them all the time

Re: socket.h

2006-01-24 Thread Simon Josefsson
Jim Meyering <[EMAIL PROTECTED]> writes: > Simon Josefsson <[EMAIL PROTECTED]> wrote: >> For some reason, mingw32 uses non-POSIX names for shutdown's > ... >> --- socket_.h09 Jan 2006 17:13:09 +0100 1.1 >> +++ socket_.h19 Jan 2006 14:39:07 +0100 >> @@ -34,4 +34,15 @@ >> # incl

Re: socket.h

2006-01-24 Thread Simon Josefsson
Bruno Haible <[EMAIL PROTECTED]> writes: > Simon Josefsson wrote: >> +#if !defined(SHUT_WR) && defined (SD_SEND) >> +# define SHUT_WR 1 >> +#endif >> +#if !defined(SHUT_RDWR) && defined (SD_BOTH) >> +# define SHUT_RDWR 2 >> +#endif > > Is SD_SEND == 1 and SD_BOTH == 2 ? Yes, although it is a mist

Re: socket.h

2006-01-23 Thread Paul Eggert
Jim Meyering <[EMAIL PROTECTED]> writes: > I find that those parentheses provide no benefit. Although coreutils > doesn't use that module, it might be worthwhile to start following the > same guideline in gnulib. I've never run into a compiler that didn't support "defined FOO", and I don't see a

Re: socket.h

2006-01-23 Thread Jim Meyering
Simon Josefsson <[EMAIL PROTECTED]> wrote: > For some reason, mingw32 uses non-POSIX names for shutdown's ... > --- socket_.h 09 Jan 2006 17:13:09 +0100 1.1 > +++ socket_.h 19 Jan 2006 14:39:07 +0100 > @@ -34,4 +34,15 @@ > # include > #endif > > +/* For shutdown(). */ > +#if !defined(SHUT_RD)