Re: rijndael

2005-10-15 Thread Jim Meyering
Simon Josefsson <[EMAIL PROTECTED]> wrote: > Jim Meyering <[EMAIL PROTECTED]> writes: > >> Simon Josefsson <[EMAIL PROTECTED]> wrote: >>> Revised patch. >> >> Do those `U' suffixes serve any purpose, >> given an array base type of uint32_t? > > I don't know. Should I remove them? Please do. I sus

Re: rijndael

2005-10-14 Thread Paul Eggert
Simon Josefsson <[EMAIL PROTECTED]> writes: > Ok to install? It's fine with me, yes. ___ bug-gnulib mailing list bug-gnulib@gnu.org http://lists.gnu.org/mailman/listinfo/bug-gnulib

Re: rijndael

2005-10-14 Thread Simon Josefsson
Paul Eggert <[EMAIL PROTECTED]> writes: > Simon Josefsson <[EMAIL PROTECTED]> writes: > >> I don't know. Should I remove them? > > Yes please; they contribute nothing and might lead an unwary reader > into thinking that they're needed for some reason. Done. Ok to install?

Re: rijndael

2005-10-14 Thread Paul Eggert
Simon Josefsson <[EMAIL PROTECTED]> writes: > I don't know. Should I remove them? Yes please; they contribute nothing and might lead an unwary reader into thinking that they're needed for some reason. ___ bug-gnulib mailing list bug-gnulib@gnu.org ht

Re: rijndael

2005-10-14 Thread Simon Josefsson
Jim Meyering <[EMAIL PROTECTED]> writes: > Simon Josefsson <[EMAIL PROTECTED]> wrote: >> Revised patch. > > Do those `U' suffixes serve any purpose, > given an array base type of uint32_t? I don't know. Should I remove them? >> Index: lib/rijndael-alg-fst.c > ... >> +static const uint32_t Te0[2

Re: rijndael

2005-10-14 Thread Jim Meyering
Simon Josefsson <[EMAIL PROTECTED]> wrote: > Revised patch. Do those `U' suffixes serve any purpose, given an array base type of uint32_t? > Index: lib/rijndael-alg-fst.c ... > +static const uint32_t Te0[256] = { > + 0xc66363a5U, 0xf87c7c84U, 0xee99U, 0xf67b7b8dU, > + 0xfff2f20dU, 0xd66b6bb

Re: rijndael

2005-10-14 Thread Simon Josefsson
Jim Meyering <[EMAIL PROTECTED]> writes: +int +rijndaelPadEncrypt (rijndaelCipherInstance * cipher, + rijndaelKeyInstance * key, unsigned char *input, + int inputOctets, unsigned char *outBuffer) > > Hmm... looking at that in isolation, I wonder if `in

Re: rijndael

2005-10-14 Thread Jim Meyering
Simon Josefsson <[EMAIL PROTECTED]> wrote: > Jim Meyering <[EMAIL PROTECTED]> writes: > >> Simon Josefsson <[EMAIL PROTECTED]> wrote: >>> Ok to install? >>> >>> Comments appreciated, of course. >> >> Hi Simon, >> >> In this function, >> >> +rijndael_rc >> +rijndaelMakeKey (rijndaelKeyInstance * ke

Re: rijndael

2005-10-14 Thread Simon Josefsson
Jim Meyering <[EMAIL PROTECTED]> writes: > Simon Josefsson <[EMAIL PROTECTED]> wrote: >> Ok to install? >> >> Comments appreciated, of course. > > Hi Simon, > > In this function, > > +rijndael_rc > +rijndaelMakeKey (rijndaelKeyInstance * key, rijndael_direction direction, > + int keyL

Re: rijndael

2005-10-14 Thread Jim Meyering
Simon Josefsson <[EMAIL PROTECTED]> wrote: > Ok to install? > > Comments appreciated, of course. Hi Simon, In this function, +rijndael_rc +rijndaelMakeKey (rijndaelKeyInstance * key, rijndael_direction direction, +int keyLen, char *keyMaterial) the keyMaterial parameter should b