Re: renameat

2009-10-02 Thread Jim Meyering
Eric Blake wrote: ... > Subject: [PATCH] rename, fchdir: don't ignore chdir failure > > Although we just checked that chdir(cwd) worked, there is a > race where it could disappear while we are temporarily away. > If that happens, forcefully give up rather than proceeding > in the wrong directory. >

Re: renameat

2009-10-02 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Jim Meyering on 10/2/2009 10:26 AM: > > The odd indentation highlights the fact there's a TAB on this line > and on the three following. If you use spaces, the code will > render readably regardless of quoting. I haven't yet quite made

Re: renameat

2009-10-02 Thread Jim Meyering
Eric Blake wrote: > According to Jim Meyering on 10/1/2009 1:28 PM: >>> Here's the current state of the series, finally ready for review. If we >>> check it in as-is, then coreutils will have everything it needs to ensure >>> consistent behavior of 'mv -T a b/' on every platform it already support

Re: renameat

2009-10-02 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Jim Meyering on 10/1/2009 1:28 PM: >> Here's the current state of the series, finally ready for review. If we >> check it in as-is, then coreutils will have everything it needs to ensure >> consistent behavior of 'mv -T a b/' on every pla

Re: renameat

2009-10-01 Thread Jim Meyering
Eric Blake wrote: > According to Jim Meyering on 10/1/2009 1:59 AM: >>> So I'm guessing that the bug was related to actual directories, where rename >>> ("dir/","new") failed (with what errno?) while rename("dir","new") >>> succeeded; >> >> That is definitely the case in question, as seen in the >

Re: renameat

2009-10-01 Thread Paolo Bonzini
On 10/01/2009 03:17 PM, Eric Blake wrote: Oops - for some reason, Windows thinks it needs to revive directory "a" once "b" is emptied out and removed. Extremely weird; unfortunately the fix requires that renaming on top of an existing directory will be non-atomic on cygwin. I'm debating about w

Re: renameat

2009-10-01 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Eric Blake on 10/1/2009 7:17 AM: > Here's the current state of the series, finally ready for review. To play with it, you can use: git pull git://repo.or.cz/gnulib/ericb.git master - -- Don't work too hard, make some time for fun as wel