Re: rename some hash code modules

2025-04-30 Thread Bruno Haible via Gnulib discussion list
Hi Pádraig, > FYI I see these failures in coreutils CI with latest gnulib. There were two mistakes, indeed. > src/copy.c: In function 'dest_info_init': > src/copy.c:2026:24: error: 'triple_hash' undeclared (first use in this > function) > 2026 |triple_hash, >|

Re: rename some hash code modules

2025-04-30 Thread Bruno Haible via Gnulib discussion list
Yesterday I did: > Rename module hash-pjw to hashcode-string. It's not that easy: We have 3 different implementations of hash codes for strings: (1) glibc/intl/hash-string.[hc] = gettext-runtime/intl/hash-string.[hc] (2) inside lib/hash.c (3) in lib/hashcode-string.[hc]. I don't want

Re: rename some hash code modules

2025-04-30 Thread Pádraig Brady
On 29/04/2025 23:57, Bruno Haible via Gnulib discussion list wrote: The naming of *hash* modules is suboptimal: On one hand, we have the hash tables and containers: hash, hash-map, hash-set, linkedhash-map, linkedhash-set, avltreehash-list, linkedhash-list, rbtreehash-list, on the other han