Re: relocatable-perl module

2014-01-16 Thread Eric Blake
On 01/16/2014 04:56 AM, Daniel Albers wrote: > > Escaping the braces as per the attached patch seems to fix this. Thanks; I added a ChangeLog entry and pushed in your name. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc D

Re: relocatable-perl module

2014-01-16 Thread Daniel Albers
On 10.01.2014 06:12, Ben Pfaff wrote: > It looks to me like you don't have direct access to the gnulib Git > repository. Do you want me to apply this on your behalf? Yes please. >>> >>> OK, I'll do that tonight. > > Thanks, I'll do that in a minute. The change causes makeinfo 5

Re: relocatable-perl module

2014-01-10 Thread Reuben Thomas
On 10 January 2014 05:12, Ben Pfaff wrote: > > I am folding in one incremental change: > > diff --git a/doc/relocatable-maint.texi b/doc/relocatable-maint.texi > index 75b1318..23b5048 100644 > --- a/doc/relocatable-maint.texi > +++ b/doc/relocatable-maint.texi > @@ -171,7 +171,8 @@ $some_datadir

Re: relocatable-perl module

2014-01-09 Thread Ben Pfaff
On Thu, Jan 09, 2014 at 10:34:36PM +, Reuben Thomas wrote: > [I'm sorry, I took us off-list a couple messages ago. Back on now.] Happens to me from time to time too. > On 9 January 2014 16:36, Ben Pfaff wrote: > > > > > > > OK, do you need me to resend the patch? > > > > If you don't mind.

Re: relocatable-perl module

2014-01-09 Thread Reuben Thomas
[I'm sorry, I took us off-list a couple messages ago. Back on now.] On 9 January 2014 16:36, Ben Pfaff wrote: > > > > OK, do you need me to resend the patch? > > If you don't mind. > Attached. > > > > It looks to me like you don't have direct access to the gnulib Git > > > repository. Do you

Re: relocatable-perl module

2014-01-08 Thread Ben Pfaff
On Wed, Jan 08, 2014 at 11:09:45AM +, Reuben Thomas wrote: > On 8 January 2014 06:10, Ben Pfaff wrote: > > > Reuben Thomas writes: > > > > > The attached patch adds a module relocatable-perl that does for Perl > > > scripts what relocatable-script does for shell scripts. > > > > It looks to

Re: relocatable-perl module

2014-01-08 Thread Reuben Thomas
On 8 January 2014 06:10, Ben Pfaff wrote: > Reuben Thomas writes: > > > The attached patch adds a module relocatable-perl that does for Perl > > scripts what relocatable-script does for shell scripts. > > It looks to me like it's successfully in the same spirit as the > shell implementation. I

Re: relocatable-perl module

2014-01-07 Thread Ben Pfaff
Reuben Thomas writes: > The attached patch adds a module relocatable-perl that does for Perl > scripts what relocatable-script does for shell scripts. It looks to me like it's successfully in the same spirit as the shell implementation. I didn't review the Perl code in detail for correctness.

Re: relocatable-perl module

2014-01-01 Thread Reuben Thomas
On 1 January 2014 13:13, Reuben Thomas wrote: > The Perl code is also rather shorter and probably more robust. > And also much clearer in intent, which makes it a better starting point for other similar modules for other languages, particularly those that can't reuse relocatable-script. It would