Re: iconv_alloc for iconvme module

2005-08-30 Thread Simon Josefsson
"Oskar Liljeblad" <[EMAIL PROTECTED]> writes: > Another thing - I think you forgot to apply the iconvme.h patch. > See below. Without it, iconvme won't compile (no iconv_alloc > declaration). Oops, fixed. Thanks, Simon ___ bug-gnulib mailing list bug

Re: iconv_alloc for iconvme module

2005-08-29 Thread Bruno Haible
Oskar Liljeblad wrote: > Thanks. I didn't know free could clobber errno. (Do you know a system > where it does?) Yes: glibc systems. free() gives back unused memory to the system by calling munmap(). munmap() can clobber errno. Bruno ___ bug-gnulib m

Re: iconv_alloc for iconvme module

2005-08-29 Thread Oskar Liljeblad
On Monday, August 29, 2005 at 10:04, Simon Josefsson wrote: [..] > Same here, free may corrupt the errno from iconv (or others) that > should be returned. Thanks. I didn't know free could clobber errno. (Do you know a system where it does?) Another thing - I think you forgot to apply the iconvme.

Re: iconv_alloc for iconvme module

2005-08-29 Thread Simon Josefsson
"Oskar Liljeblad" <[EMAIL PROTECTED]> writes: > Here's a patch adding a function iconv_alloc to the iconvme module. > It differs from the function iconv_string in that it takes a previously > opened iconv descriptor instead of the explicit codeset names. Thanks! I installed this, after fixing tw