Hi Bruno,
Bruno Haible writes:
> Reviewing the new code now, I see a couple of details that can be improved:
Thanks, your changes make things much cleaner.
Collin
Hi Collin,
> I believe the slowness in --extract-dependents caused by my previous
> patch was caused by the parsing of all files in modules/* done during
> GLModules.__init__().
Yes.
> Your implementation was faster for the non-recursive case, so I've added
> it back with very minor changes and
Hi Bruno,
Collin Funk writes:
> Thanks, I reproduced your findings. I'll have a look at fixing it with
> your suggestions.
I've applied a patch following your suggestions.
I believe the slowness in --extract-dependents caused by my previous
patch was caused by the parsing of all files in modul
Hi Bruno,
Bruno Haible writes:
> Could you please fix the ChangeLog entry (s/dependencies/dependents/)?
Oops, good catch. Fixed with the attached.
> And I also see a performance regression in one case:
>
> $ time ./gnulib-tool --extract-dependents stdlib
> $ time ./gnulib-tool --extract-depend
Hi Collin,
> A while ago I said that I would have a look at optimizing the
> --extract-recursive-dependencies option you implemented in gnulib-tool.
> Then I forgot about it.
>
> I've written and pushed the change finally.
>
> Here was my testing:
>
> $ time gnulib-tool --extract-recursive-
