Re: gnulib-tool.py: Omit some unnecessary list() calls around sorted().

2024-04-08 Thread Bruno Haible
Hi Collin, > I was having a look at GLModuleSystem.py and noticed some duplicate > checks that an key is valid. Patch 0003 addresses that. > > Patch 0004 adds a missing None return type hint to > GLModuleTable.getCondition(). This is used to indicate that the module > is not a conditional depende

Re: gnulib-tool.py: Omit some unnecessary list() calls around sorted().

2024-04-08 Thread Bruno Haible
Hi Collin, > Here is two janitorial work patches. Thanks, applied. > I remember an extra dict() call causing trouble with GLMakefileTable. > Removing the extra list() calls from sorted() seemed like a good place > to start cleaning up. Well, that extra dict() call made trouble because in that p

Re: gnulib-tool.py: Omit some unnecessary list() calls around sorted().

2024-04-07 Thread Collin Funk
On 4/7/24 10:57 PM, Collin Funk wrote: > it is compatible with Python 3.7 It is *not* compatible with Python 3.7. It only works with Python 3.8+. My bad... Collin

Re: gnulib-tool.py: Omit some unnecessary list() calls around sorted().

2024-04-07 Thread Collin Funk
Hi Bruno, I was having a look at GLModuleSystem.py and noticed some duplicate checks that an key is valid. Patch 0003 addresses that. Patch 0004 adds a missing None return type hint to GLModuleTable.getCondition(). This is used to indicate that the module is not a conditional dependency. I missed