Re: gnulib-tool.py: Fix crash when no ACLOCAL_AMFLAGS is found.

2024-07-05 Thread Collin Funk
Paul Eggert writes: > Right, but the glitch is worth documenting. I installed the attached > into Autoconf. Thanks! Collin

Re: gnulib-tool.py: Fix crash when no ACLOCAL_AMFLAGS is found.

2024-07-05 Thread Paul Eggert
On 6/2/24 14:51, Collin Funk wrote: I don't know enough about Autotools to tell if anything silly can be done using this trick. Not that you would run auto* in a project that you don't trust anyways... Right, but the glitch is worth documenting. I installed the attached into Autoconf.From 3a7a

Re: gnulib-tool.py: Fix crash when no ACLOCAL_AMFLAGS is found.

2024-06-02 Thread Bruno Haible
Collin Funk wrote: > Thanks, I've applied the attached patch fixing that regular expression. Thanks. Now it appears to work fine. Bruno

Re: gnulib-tool.py: Fix crash when no ACLOCAL_AMFLAGS is found.

2024-06-02 Thread Collin Funk
Bruno Haible writes: >> > Thanks for this recipe. I think this is worth a unit test, since it >> > is a special case that is otherwise not tested. >> >> Agreed. I can add one later today. > > I added it already. Thanks, I've applied the attached patch fixing that regular expression. Also, Paul

Re: gnulib-tool.py: Fix crash when no ACLOCAL_AMFLAGS is found.

2024-06-02 Thread Bruno Haible
Hi Collin, > > Thanks for this recipe. I think this is worth a unit test, since it > > is a special case that is otherwise not tested. > > Agreed. I can add one later today. I added it already. Bruno

Re: gnulib-tool.py: Fix crash when no ACLOCAL_AMFLAGS is found.

2024-06-02 Thread Collin Funk
Hi Bruno, Bruno Haible writes: > Thanks for this recipe. I think this is worth a unit test, since it > is a special case that is otherwise not tested. Agreed. I can add one later today. > The regular expression doesn't seem right: [...] > The point of using a non-greedy operator is to not incl

Re: gnulib-tool.py: Fix crash when no ACLOCAL_AMFLAGS is found.

2024-06-02 Thread Bruno Haible
Hi Collin, > Not sure how this didn't get found sooner, to be honest. Here is an > example of the bug: > > $ git clone https://git.savannah.gnu.org/git/rcs.git > $ cd rcs > $ git checkout next > $ sh -x autogen.sh Thanks for this recipe. I think this is worth a unit test, since i