Re: gnulib-tool.py: Fix 'consider-using-with' pylint warnings.

2024-04-05 Thread Collin Funk
Hi Bruno, On 4/5/24 5:58 AM, Bruno Haible wrote: > Sure. It was a translation of the shell code: Ah, yeah that makes sense. > Finding the maximum of a list directly is O(N). Finding it by sorting > the list is O(N log N). Therefore it is clear which of the two should > be preferred :) I was loo

Re: gnulib-tool.py: Fix 'consider-using-with' pylint warnings.

2024-04-05 Thread Bruno Haible
Hi Collin, > I've just changed these to 'sp.run()' since that function deals with > everything for us and is recommended. Yes, sp.run() and sp.call() are the variants that are most easy to use. > The second is 'consider-using-set-comprehension'. Instead of calling > set() on a list comprehension