Re: gnulib-tool --extract-filelist whitespace diff fix

2024-03-21 Thread Collin Funk
Hi Bruno, On 3/21/24 8:50 AM, Bruno Haible wrote: > Thanks, applied. With a small tweak in main.py, to make the 3 added files > more symmetric: Looks good. I was conflicted on whether or not to do this in the original patch. Collin

Re: gnulib-tool --extract-filelist whitespace diff fix

2024-03-21 Thread Bruno Haible
Hi Collin, > This patch makes the python version behave the same way as well. > I'm not sure if any files in modules/* have extra newlines like this, > but the more close the gnulib-tool's behave the better. Thanks, applied. With a small tweak in main.py, to make the 3 added files more symmetric:

Re: gnulib-tool --extract-filelist whitespace diff fix

2024-03-20 Thread Collin Funk
Hi Bruno, On 3/19/24 11:24 PM, Bruno Haible wrote: > It would be better to define a method getFiles_Raw -> str, > similarly to how getLicense_Raw is defined, and have > getFiles -> list > use that. Yes, that is a better idea. Here is a patch that does this. I beleive that this should match gnulib

Re: gnulib-tool --extract-filelist whitespace diff fix

2024-03-19 Thread Bruno Haible
Collin Funk wrote: > I am hesitant to change the GLModule.getFiles() function to include an > empty string just so that joining the lines emits an empty line. > > This solution should work. This solution is too much of a hack. It would be better to define a method getFiles_Raw -> str, similarly