Re: getloadavg test

Hi Paul, > Sure, something like that sounds fine. Though I'd > make the upper bound higher than 100. Maybe a million? > ... high load factors are not that uncommon on real-world > multiple-CPU machines. Thanks for the advice. I pushed it with 100 as plausibility limit. Bruno -- In memoria

Re: getloadavg test

On 02/16/2011 03:28 AM, Bruno Haible wrote: How about this? It's basically what a human would do when executing the manual test. Sure, something like that sounds fine. Though I'd make the upper bound higher than 100. Maybe a million? Sun bug 4756989 was a user complaining that SunOS getloada

Re: getloadavg test

Hi Paul, A test can be non-silent when there is a hint that it is not working correctly. For example, if the getloadavg() values are all 0, or if there is a problem with the scaling. How about this? It's basically what a human would do when executing the manual test. 2011-02-16 Bruno Haible

Re: getloadavg test

Thanks for that review, Bruno. I'll add the following before pushing: From c46ceeaabfab5055455daf282e64bc37d3a98ea9 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Tue, 15 Feb 2011 13:09:20 -0800 Subject: [PATCH] test-getloadavg: make it act like other tests Suggested by Bruno Haible in

Re: getloadavg test

Hi Paul, > Move test code to ... > * tests/test-getloadavg.c: New file, containing previous > contents of test from lib/getloadavg.c. > * modules/getloadavg-tests: New file. This test can be run in two modes: - simple test: call getloadavg once, and print one line. - repeated test: call getlo