Re: getline.h

2007-09-29 Thread Bruno Haible
Eric Blake wrote on 2007-08-22: > * lib/stdio_.h (getdelim, getline): Declare. Small improvement of the doc: Say that getline reads a line. "Return" not "Returns" (GNU style conventions). List the identifiers in the prototype. 2007-09-29 Bruno Haible <[EMAIL PROTECTED]> * lib/st

Re: getline.h

2007-09-09 Thread Bruno Haible
Eric Blake wrote: > Here's what I'm committing; I think it addresses all your points. > > 2007-08-22 Eric Blake <[EMAIL PROTECTED]> > > Getline touchups. > * lib/getdelim.c (getdelim): Revert regression that required *n to > be 0 when *lineptr is NULL. Preserve errno across f

Re: getline.h

2007-08-23 Thread Jim Meyering
Simon Josefsson <[EMAIL PROTECTED]> wrote: > Jim Meyering <[EMAIL PROTECTED]> writes: >> [is this ok with you, Simon? ] > > Yes, please add it. Committed.

Re: getline.h

2007-08-23 Thread Simon Josefsson
Jim Meyering <[EMAIL PROTECTED]> writes: > [is this ok with you, Simon? ] Yes, please add it. /Simon

Re: getline.h

2007-08-23 Thread Jim Meyering
Eric Blake <[EMAIL PROTECTED]> wrote: > According to Eric Blake on 8/22/2007 6:04 PM: >> According to Bruno Haible on 8/22/2007 3:02 PM: >>> Hi Eric, >> >>> Thanks for working on this, and for the unit tests. The patch - excluding >>> the one of getdelim.c - is nearly perfect. But I see three prob

Re: getline.h

2007-08-22 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Eric Blake on 8/22/2007 6:04 PM: > According to Bruno Haible on 8/22/2007 3:02 PM: >> Hi Eric, > >> Thanks for working on this, and for the unit tests. The patch - excluding >> the one of getdelim.c - is nearly perfect. But I see three pr

Re: getline.h

2007-08-22 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Bruno Haible on 8/22/2007 3:02 PM: > Hi Eric, > > Thanks for working on this, and for the unit tests. The patch - excluding > the one of getdelim.c - is nearly perfect. But I see three problems: Thanks for catching the nits. Please feel

Re: getline.h

2007-08-22 Thread Bruno Haible
Hi Eric, Thanks for working on this, and for the unit tests. The patch - excluding the one of getdelim.c - is nearly perfect. But I see three problems: 1) You define the shell variable HAVE_DECL_GETDELIM depending whether the function exists, not whether the function is declared. But for examp

Re: getline.h

2007-08-22 Thread Jim Meyering
Eric Blake <[EMAIL PROTECTED]> wrote: > 2007-08-21 Eric Blake <[EMAIL PROTECTED]> > > Move getline and getdelim into stdio.h, per POSIX 200x. ... Thanks for doing that. I've adjusted coreutils accordingly: http://git.sv.gnu.org/gitweb/?p=coreutils.git

Re: getline.h

2007-08-22 Thread Simon Josefsson
Eric Blake <[EMAIL PROTECTED]> writes: > According to Jim Meyering on 8/19/2007 2:18 PM: >> Eric Blake <[EMAIL PROTECTED]> wrote: >>> I could go either way, although I'm leaning toward doing it now; >> >> I agree. Doing it now is fine. > > How about this for the patch, then? Simon, this is your

Re: getline.h

2007-08-21 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Jim Meyering on 8/19/2007 2:18 PM: > Eric Blake <[EMAIL PROTECTED]> wrote: >> I could go either way, although I'm leaning toward doing it now; > > I agree. Doing it now is fine. How about this for the patch, then? Simon, this is your m

Re: getline.h

2007-08-19 Thread Jim Meyering
Eric Blake <[EMAIL PROTECTED]> wrote: > I could go either way, although I'm leaning toward doing it now; I agree. Doing it now is fine.

Re: getline.h

2007-08-19 Thread Paul Eggert
Eric Blake <[EMAIL PROTECTED]> writes: > I could go either way, although I'm leaning toward doing it now; I'll wait > for anyone else to speak their mind. I also lean towards doing it now, since I think it unlikely that POSIX will change much before becoming official in this area, and anyway its

Re: getline.h

2007-08-18 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Bruno Haible on 8/18/2007 4:36 PM: > Eric Blake wrote: >> Now that POSIX 200x is standardizing getline and getdelim as part of >> , should we get rid of getline.h and beef up stdio_.h, then >> adjust all the callers (such as yesno.c) to as

Re: getline.h

2007-08-18 Thread Bruno Haible
Eric Blake wrote: > Now that POSIX 200x is standardizing getline and getdelim as part of > , should we get rid of getline.h and beef up stdio_.h, then > adjust all the callers (such as yesno.c) to assume this? Hmm, can't we wait until the POSIX standard with these changes is official? Arguments pr