Re: getgroups improvements

2009-11-13 Thread Jim Meyering
Eric Blake wrote: > According to Eric Blake on 11/12/2009 11:41 AM: >> getgroups replaces a library function, so it should not exit(). On the other >> hand, the mgetgroups interface from coreutils is much nicer to use (one call, >> instead of 2); that would be a reasonable place to add an xalloc-d

Re: getgroups improvements

2009-11-13 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Eric Blake on 11/12/2009 11:41 AM: > getgroups replaces a library function, so it should not exit(). On the other > hand, the mgetgroups interface from coreutils is much nicer to use (one call, > instead of 2); that would be a reasonabl

Re: getgroups improvements

2009-11-13 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Jim Meyering on 11/13/2009 2:14 AM: >> Any problems with committing this series? >> >> Eric Blake (5): >> getgroups: fix logic error >> getgroups: avoid calling exit >> getgroups: provide stub for mingw >> getgroups

Re: getgroups improvements

2009-11-13 Thread Jim Meyering
Eric Blake wrote: > These days, I'm not sure how many systems still need the getgroups replacement > because the system getgroups is buggy. However, there is the issue of mingw, > which lacks getgroups, and for that matter, any notion of group management > (well, windows does have groups, as evide