Re: enforcing the use of string.h related modules

2007-02-02 Thread Paul Eggert
Eric Blake <[EMAIL PROTECTED]> writes: > I reverted the mountlist change, thanks to Bruno's string_.h latest patch not > being so vocal about the use of strstr. This brings both regex and mountlist > back to their state prior to the string link warnings, No it doesn't; regex still has a mempcp

Re: enforcing the use of string.h related modules

2007-02-02 Thread Eric Blake
Paul Eggert CS.UCLA.EDU> writes: > > Eric Blake byu.net> writes: > > > * modules/mountlist (Depends-on): Add strstr > > The other parts of your patch might be needed, but these aren't quite > right. As far as I can tell, regex does not depend on mempcpy, nor > does mountlist depend on st

Re: enforcing the use of string.h related modules

2007-02-01 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Eric Blake on 1/31/2007 10:00 PM: > > Also, I noticed that the dependency of > string.h: string_h > is not strong enough - fixing your typo changed configure from declaring > GNULIB_strcase to GNULIB_STRCASE, but did not regenerate strin

Re: enforcing the use of string.h related modules

2007-02-01 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Paul Eggert on 2/1/2007 1:03 AM: > Eric Blake <[EMAIL PROTECTED]> writes: > >> * modules/regex (Depends-on): Add mempcpy. >> ... >> * modules/mountlist (Depends-on): Add strstr > > The other parts of your patch might be needed,

Re: enforcing the use of string.h related modules

2007-02-01 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Paul Eggert on 2/1/2007 1:03 AM: > Eric Blake <[EMAIL PROTECTED]> writes: > >> * modules/regex (Depends-on): Add mempcpy. >> ... >> * modules/mountlist (Depends-on): Add strstr > > The other parts of your patch might be needed,

Re: enforcing the use of string.h related modules

2007-02-01 Thread Paul Eggert
Eric Blake <[EMAIL PROTECTED]> writes: > * modules/regex (Depends-on): Add mempcpy. > ... > * modules/mountlist (Depends-on): Add strstr The other parts of your patch might be needed, but these aren't quite right. As far as I can tell, regex does not depend on mempcpy, nor does mount

Re: enforcing the use of string.h related modules

2007-01-31 Thread Eric Blake
Eric Blake byu.net> writes: > > I see that while I was typing this, you checked in your original proposed > change. But with your patch applied, I get the following: Another one: gcc -std=gnu99 -I. -I/usr/local/include -g2 -Wall -Werror -MT mountlist.o - MD -MP -MF .deps/mountlist.Tpo -

Re: enforcing the use of string.h related modules

2007-01-31 Thread Eric Blake
Eric Blake byu.net> writes: > Contrary to the Changelog entry, I don't see gl_STRING_MODULE_INDICATOR defined > in string_h.m4. > I see that while I was typing this, you checked in your original proposed change. But with your patch applied, I get the following: gcc -I. -I../../lib -g2

Re: enforcing the use of string.h related modules

2007-01-31 Thread Bruno Haible
Eric Blake wrote: > Contrary to the Changelog entry, I don't see gl_STRING_MODULE_INDICATOR > defined > in string_h.m4. Oops, forgot to commit this one. Sorry. Should be better now. Bruno

Re: enforcing the use of string.h related modules

2007-01-31 Thread Eric Blake
Bruno Haible clisp.org> writes: > > > Here is a proposed patch, that leads to a link error if someone > > > uses stpcpy() without the 'stpcpy' module (assuming the 'string' module > > > is present - which is quite likely since so much depends on it). > > > There were also no objections, so I appl

Re: enforcing the use of string.h related modules

2007-01-31 Thread Bruno Haible
Eric Blake wrote: > > Here is a proposed patch, that leads to a link error if someone > > uses stpcpy() without the 'stpcpy' module (assuming the 'string' module > > is present - which is quite likely since so much depends on it). > > Sounds like a great idea to me. OK, thanks for this opinion. T

Re: enforcing the use of string.h related modules

2007-01-27 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Bruno Haible on 1/27/2007 8:10 AM: > > Most of us are developing on sane systems with few broken or missing > functions. If, for example, someone uses the 'string' module and stpcpy(), > he will not get a warning: /usr/include/string.h de