Re: crc: gcc warnings

2024-11-01 Thread Bruno Haible via Gnulib discussion list
Simon Josefsson wrote: > > I think that the proper fix is to change the prototypes of the 4 functions > > in crc.h from 'const char *buf' to 'const void *buf'. Just like memset(), > > memcmp(), etc. take 'void *', not 'char *', parameters. > > > > What do you think? > > Ouch. Ideally maybe uint8_

Re: crc: gcc warnings

2024-11-01 Thread Simon Josefsson via Gnulib discussion list
Bruno Haible via Gnulib discussion list writes: > Hi Simon, > > Compiling a testdir of module 'crc' with "gcc -Wall", I see these warnings: ... > I think that the proper fix is to change the prototypes of the 4 functions > in crc.h from 'const char *buf' to 'const void *buf'. Just like memset(),