Re: copy-file: Silence gcc warnings

2023-05-26 Thread Paul Eggert
On 2023-05-26 15:41, Bruno Haible wrote: Maybe by defining error and error_at_line as inline functions They're defined by glibc, no? The definitions might collide. Also, I suppose the compiler might not inline them and then we'd get a diagnostic anyway. The basic problem is that the old 'er

Re: copy-file: Silence gcc warnings

2023-05-26 Thread Bruno Haible
Pádraig Brady wrote: > FWIW grep/coreutils use a die() wrapper to achieve this > for this common idiom. > > [Link to github.com elided] https://git.savannah.gnu.org/gitweb/?p=coreutils.git;a=commitdiff;h=dad7ab0b7 Thanks for the pointer. Can we do better than that, without a 'die' macro? Maybe b

Re: copy-file: Silence gcc warnings

2023-05-26 Thread Pádraig Brady
On 26/05/2023 18:34, Bruno Haible wrote: In GNU gettext, I see these compilation warnings with gcc 13.1.0: gcc ... -Wall -Wno-cast-qual -Wno-conversion -Wno-float-equal -Wno-sign-compare -Wno-undef -Wno-unused-function -Wno-unused-parameter -Wno-float-conversion -Wimplicit-fallthrough -Wno-ped