On 2014-09-16 Pádraig Brady wrote:
> I've adjusted and pushed your patch accordingly at:
> http://git.sv.gnu.org/gitweb/?p=gnulib.git;a=commitdiff;h=5549ef8
Now, on CentOS 8, with GCC 8.2.1 RedHat variant, I get this warning:
gl_avltree_list.c:67:1: warning: 'const' attribute on function returnin
On 09/09/2014 12:09 AM, Dylan Cali wrote:
> On Mon, Sep 8, 2014 at 10:04 AM, Dylan Cali wrote:
>> On Sep 8, 2014 9:27 AM, "Eric Blake" wrote:
>>> Does this work for all supported versions of gcc? Or do you need to make
>>> it conditional on new enough gcc (it's okay if warnings have to be
>>> dis
On Mon, Sep 8, 2014 at 10:04 AM, Dylan Cali wrote:
> On Sep 8, 2014 9:27 AM, "Eric Blake" wrote:
>> Does this work for all supported versions of gcc? Or do you need to make
>> it conditional on new enough gcc (it's okay if warnings have to be
>> disabled to compile with older gcc, but not okay if
On Sep 8, 2014 9:27 AM, "Eric Blake" wrote:
> Does this work for all supported versions of gcc? Or do you need to make
> it conditional on new enough gcc (it's okay if warnings have to be
> disabled to compile with older gcc, but not okay if the way to disable
> warnings for newer gcc causes compi
On 09/06/2014 07:42 PM, Dylan Cali wrote:
> On Sat, Sep 6, 2014 at 7:30 PM, Paul Eggert wrote:
>> On second thought this doesn't look wise, as the function is not expected to
>> be exported to ordinary clients, only to the test cases. So let's leave the
>> .h file alone, and put a declaration in
On Sat, Sep 6, 2014 at 7:30 PM, Paul Eggert wrote:
> On second thought this doesn't look wise, as the function is not expected to
> be exported to ordinary clients, only to the test cases. So let's leave the
> .h file alone, and put a declaration in the .c file instead.
>
> I suppose a pragma is
Dylan Cali wrote:
--- a/lib/gl_avltree_list.h
+++ b/lib/gl_avltree_list.h
@@ -24,6 +24,7 @@
extern "C" {
#endif
+extern void gl_avltree_list_check_invariants (gl_list_t list);
On second thought this doesn't look wise, as the function is not
expected to be exported to ordinary clients, onl
On Fri, Sep 5, 2014 at 10:51 AM, Paul Eggert wrote:
> Thanks, it looks like some declarations are missing in the corresponding .h
> file, or are missing attributes that they should have. Is that something
> you could write a patch for?
Hi Paul,
Attached is a patch for the attribute and declarat
Sure, I'll take a look when I have a moment.
Thanks,
Dylan
On Fri, Sep 5, 2014 at 10:51 AM, Paul Eggert wrote:
> Thanks, it looks like some declarations are missing in the corresponding .h
> file, or are missing attributes that they should have. Is that something
> you could write a patch for?
Thanks, it looks like some declarations are missing in the corresponding
.h file, or are missing attributes that they should have. Is that
something you could write a patch for?
10 matches
Mail list logo
