Re: bug#10953: Potential logical bug in readtokens.c

2012-03-06 Thread Paul Eggert
On 03/06/2012 03:32 PM, Eric Blake wrote: > Why not just strchr instead of building up an isdelim bitmap? strchr would not be right, since '\0' is valid in data and as a delimiter. No doubt you meant 'memchr'; but using 'memchr' would slow down readtoken by about a factor of two. I got this resu

Re: bug#10953: Potential logical bug in readtokens.c

2012-03-06 Thread Eric Blake
[adding gnulib, since the code in question lives there] On 03/06/2012 04:21 PM, Paul Eggert wrote: > Thanks, I agree that code is potentially buggy. I don't see > any way to trigger the bug in coreutils, but it's just asking > for trouble. Here's a proposed patch. > >>From 4954a3517397dadd217d6