Re: argp: listen to gcc warnings

2007-03-24 Thread Jim Meyering
Bruno Haible <[EMAIL PROTECTED]> wrote: > Eric Blake wrote: >> Rather than use lots of casts, coreutils does this in a common header: >> >> /* Convert a possibly-signed character to an unsigned character. This is >>a bit safer than casting to unsigned char, since it catches some type >>er

Re: argp: listen to gcc warnings

2007-03-24 Thread Bruno Haible
Eric Blake wrote: > Rather than use lots of casts, coreutils does this in a common header: > > /* Convert a possibly-signed character to an unsigned character. This is >a bit safer than casting to unsigned char, since it catches some type >errors that the cast doesn't. */ > static inline

Re: argp: listen to gcc warnings

2007-03-24 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Bruno Haible on 3/24/2007 5:22 AM: > > When you look at the code, you see that the user only has to set the variable > ARGP_HELP_FMT to a value containing non-ASCII characters, to make the program > crash. Note that the code in glibc does