Re: Warnings to be fixed

2008-10-18 Thread Jim Meyering
Bruno Haible <[EMAIL PROTECTED]> wrote: > Jim Meyering wrote: >> +2008-10-16 Jim Meyering <[EMAIL PROTECTED]> >> + >> +openat-die.c: avoid 'no previous prototype' warning >> +* lib/openat-die.c: Include "openat.h". >> +Reported by Reuben Thomas <[EMAIL PROTECTED]>. > > Thanks to this

Re: Warnings to be fixed

2008-10-18 Thread Bruno Haible
Jim Meyering wrote: > +2008-10-16 Jim Meyering <[EMAIL PROTECTED]> > + > + openat-die.c: avoid 'no previous prototype' warning > + * lib/openat-die.c: Include "openat.h". > + Reported by Reuben Thomas <[EMAIL PROTECTED]>. Thanks to this change, I now get a compilation error when comp

Re: Warnings to be fixed

2008-10-18 Thread Bruno Haible
Reuben Thomas wrote: > gl_anylinked_list2.h: In function ‘gl_linked_iterator’: > gl_anylinked_list2.h:818: warning: ‘result.j’ is used uninitialised in this > function > gl_anylinked_list2.h:818: warning: ‘result.i’ is used uninitialised in this > function > gl_anylinked_list2.h:818: warning: ‘re

Re: Warnings to be fixed

2008-10-18 Thread Bruno Haible
Reuben Thomas wrote: > In general, I reiterate the principle I implied with my request that > #include_next warnings be suppressed some time ago: gnulib (and source > libraries in general) should not generate warnings. As explained in [1]: We cannot guarantee no warning. If you find warnings obt

Re: Warnings to be fixed

2008-10-18 Thread Jim Meyering
Jim Meyering <[EMAIL PROTECTED]> wrote: > Paul Eggert <[EMAIL PROTECTED]> wrote: >> Jim Meyering <[EMAIL PROTECTED]> writes: >> >>> mode = (sizeof (mode_t) < sizeof (int) >>> ? va_arg (ap, int) >>> : va_arg (ap, mode_t));<<< line 43 >>> >>> IMHO, adding cas

Re: Warnings to be fixed

2008-10-16 Thread Reuben Thomas
On Thu, 16 Oct 2008, Jim Meyering wrote: This one is perhaps a good reason to turn off or ignore that warning, Thanks to Paul Eggert for finding an acceptable solution. In general, I reiterate the principle I implied with my request that #include_next warnings be suppressed some time ago: gn

Re: Warnings to be fixed

2008-10-16 Thread Jim Meyering
Paul Eggert <[EMAIL PROTECTED]> wrote: > Jim Meyering <[EMAIL PROTECTED]> writes: > >> mode = (sizeof (mode_t) < sizeof (int) >>? va_arg (ap, int) >>: va_arg (ap, mode_t));<<< line 43 >> >> IMHO, adding casts here just to avoid that warning would be >>

Re: Warnings to be fixed

2008-10-16 Thread Paul Eggert
Jim Meyering <[EMAIL PROTECTED]> writes: > mode = (sizeof (mode_t) < sizeof (int) > ? va_arg (ap, int) > : va_arg (ap, mode_t));<<< line 43 > > IMHO, adding casts here just to avoid that warning would be > counterproductive. I agree. But would it tur

Re: Warnings to be fixed

2008-10-16 Thread Jim Meyering
Reuben Thomas <[EMAIL PROTECTED]> wrote: > Compiling with the Debian gnulib snapshot of 20081001, I am delighted > that I no longer get warnings about #include_next. (Un?)fortunately, > this enables me more easily to spot "real" warnings: ... > open-safer.c: In function ‘open_safer’: > open-safer.c

Re: Warnings to be fixed

2008-10-16 Thread Jim Meyering
Reuben Thomas <[EMAIL PROTECTED]> wrote: ... > openat-die.c:31: warning: no previous prototype for ‘openat_save_fail’ > openat-die.c:44: warning: no previous prototype for ‘openat_restore_fail’ > open-safer.c: In function ‘open_safer’: > open-safer.c:43: warning: signed and unsigned type in conditi