Re: Refactoring rewrite_filename functions

2024-04-17 Thread Bruno Haible
Hi Collin, > This will require some code reordering first though. The > GLFileAssistant used by GLImport is not defined until > GLImport.execute(). The file name transformations are done in > GLImport.prepare(). Good point. > I think the correct solution there is to define the GLFileAssistant in

Re: Refactoring rewrite_filename functions

2024-04-16 Thread Collin Funk
On 4/16/24 6:35 PM, Bruno Haible wrote: > This does not make sense. GLConfig is meant to hold settings and > configuration, > nothing more. > > I see the home of this function more in GLFileSystem.py. Maybe in class > GLFileAssistant, maybe in a new class in that same file. Hmm, thanks for the a

Re: Refactoring rewrite_filename functions

2024-04-16 Thread Bruno Haible
Hi Collin, > I'm thinking of making this function accept a single filename instead > of a list Makes sense, as previously discussed. > and then moving it to GLConfig. This does not make sense. GLConfig is meant to hold settings and configuration, nothing more. I see the home of this function m