Re: Dead code in hol_entry_help

2016-01-11 Thread Paul Eggert
On 01/10/2016 11:14 PM, Andrei Borzenkov wrote: It looks like it fixes both problems (and as far as I can tell, some more NULL dereferences of state variable). "./gnulib-tool --test argp" fails, though, which suggests more work is needed.

Re: Dead code in hol_entry_help

2016-01-10 Thread Andrei Borzenkov
On Mon, Jan 11, 2016 at 9:56 AM, Paul Eggert wrote: > Andrei Borzenkov wrote: >> >> It looks like assignment to first_long_opt is >> missing somewhere. > > > It seems to have been missing ever since it was added. > > I assume that both bugs you mentioned don't occur in glibc. Perhaps all we > need

Re: Dead code in hol_entry_help

2016-01-10 Thread Paul Eggert
Andrei Borzenkov wrote: It looks like assignment to first_long_opt is missing somewhere. It seems to have been missing ever since it was added. I assume that both bugs you mentioned don't occur in glibc. Perhaps all we need to do is to merge glibc's argp changes into gnulib. Attached is a fir