Re: Adding Cygwin and MSYS2 to DEPENDENCIES

2024-05-02 Thread Collin Funk
On 5/2/24 3:50 PM, Bruno Haible wrote: >> Would the following be correct? >> >> command = ['sh', '-c', f'patch {shlex.quote(test_driver)} < >> {shlex.quote(diff)}'] >> try: >> result = sp.call(command, stdout=sp.DEVNULL, stderr=sp.DEVNULL) >> except OSError as exc: >>

Re: Adding Cygwin and MSYS2 to DEPENDENCIES

2024-05-02 Thread Bruno Haible
Collin Funk wrote: > Ah, good point. I didn't realize it was possible to use a native > Windows Python3 (os.name == 'nt') with Cygwin tools. It appears that's what the original reporter is doing [1]: you see file names with backslashes and you see Windows error codes being reported, rather than PO

Re: Adding Cygwin and MSYS2 to DEPENDENCIES

2024-05-02 Thread Collin Funk
On 5/2/24 3:28 PM, Bruno Haible wrote: >> Can I apply the attached patched? > > Yes, now it is OK to push. Done. >> Also, last night when fixing the quoting issue I was thinking if >> gnulib-tool.py should quit on unsupported platforms (native Windows). > > Yes, this is reasonable, since we alr

Re: Adding Cygwin and MSYS2 to DEPENDENCIES

2024-05-02 Thread Bruno Haible
Hi Collin, > Can I apply the attached patched? Yes, now it is OK to push. > Also, last night when fixing the quoting issue I was thinking if > gnulib-tool.py should quit on unsupported platforms (native Windows). Yes, this is reasonable, since we already determined that our unsupported platform

Re: Adding Cygwin and MSYS2 to DEPENDENCIES

2024-05-02 Thread Collin Funk
Hi Bruno, On 5/2/24 2:29 AM, Bruno Haible wrote: > I would additionally format it as a subsection, so that it clearly stands > out from the rest: Can I apply the attached patched? Also, last night when fixing the quoting issue I was thinking if gnulib-tool.py should quit on unsupported platforms

Re: Adding Cygwin and MSYS2 to DEPENDENCIES

2024-05-02 Thread Bruno Haible
Hi Collin, > I read the emails you sent and INSTALL.windows in gettext. How about > this revised version based on that information? > > Since Cygwin is preferred we can just have a single section for that. > Mention explicitly that it is preferred over MSYS2. Pretty good already. > diff --git a

Re: Adding Cygwin and MSYS2 to DEPENDENCIES

2024-05-01 Thread Collin Funk
Hi Bruno, On 5/1/24 5:35 PM, Bruno Haible wrote: > This details about the two packages are correct. But the impression that > the entire DEPENDENCIES file would give is not right. Namely, the > impression is that all users need not only 'make', 'm4', ..., 'tar', > but also Cygwin and MSYS2. > > I

Re: Adding Cygwin and MSYS2 to DEPENDENCIES

2024-05-01 Thread Bruno Haible
Hi Collin, > Before I add Cygwin and MSYS2 to the DEPENDENCIES file can you double > check them? This details about the two packages are correct. But the impression that the entire DEPENDENCIES file would give is not right. Namely, the impression is that all users need not only 'make', 'm4', ...,