Re: [PATCHES] Various gnulib improvements mostly around Windows

2025-02-15 Thread Bruno Haible via Gnulib discussion list
Mitch Capper wrote: > > In Gnulib, we use > > #if defined _WIN32 && !defined __CYGWIN__ > > If I understand correctly anywhere I am using _WIN32 I should update it to > this dual check as cygwin may have this _WIN32 definition but it should be > treated not as _WIN32. Yes. > > Yes, that's an ad

Re: [PATCHES] Various gnulib improvements mostly around Windows

2025-02-15 Thread Mitch Capper
Thanks Bruno for such detailed notes. I will start to work on cleaning up the patches to prep for the mailing list. > When a package has complicated fork/exec logic, generally it's advisable to > use the posix_spawn facility when possible. This provides not only portability > to native Windows; i

Re: [PATCHES] Various gnulib improvements mostly around Windows

2025-02-15 Thread Bruno Haible via Gnulib discussion list
Hello Mitch, > I have been working on a high level of windows compatibility for several > GNU and other related open source software without the traditional > emulation layers/mingw requirements. Overall it has had great success in > my mind, multiple dozens of GNU related packages compiled from