Re: [PATCH v2] stat-time: silence -Wunused-parameter regression

2018-01-03 Thread Tim Rühsen
... here is another one in lib/cdef.h occurring with a MinGW build. In file included from ../lib/libc-config.h:149:0, from ../lib/glob.h:24, from utils.c:35: ../lib/cdefs.h:298:6: warning: "__USE_FORTIFY_LEVEL" is not defined, evaluates to 0 [-Wundef] # if __US

Re: [PATCH v2] stat-time: silence -Wunused-parameter regression

2018-01-02 Thread Paul Eggert
Jim Meyering wrote: Thanks. That sounds like the right approach. We have to hold user-included headers to a higher standard. Right, I missed that. Thanks, Eric.

Re: [PATCH v2] stat-time: silence -Wunused-parameter regression

2018-01-02 Thread Jim Meyering
On Tue, Jan 2, 2018 at 1:56 PM, Eric Blake wrote: > Commit 2c5d5587 causes warnings on non-Sun systems when compiled > under -Wunused-parameter; we've previously tweaked code in commit > 81eb8486 to avoid such warnings. Prefer an attribute rather than > a cast to void (the attribute is always oka