Re: [PATCH 10/21] binary-io: put fd in binary mode if it is not a console on EMX

2014-12-01 Thread KO Myung-Hun
Hi/2. Bruno Haible wrote: >> * lib/binary-io.h (SET_BINARY): put fd in binary mode if it is not a >> console on EMX. > > A changelog entry should usually specify the difference between the previous > behaviour and the new behaviour. Therefore here it should better read: > > * lib/binary-io.h (SE

Re: [PATCH 10/21] binary-io: put fd in binary mode if it is not a console on EMX

2014-11-30 Thread Bruno Haible
> * lib/binary-io.h (SET_BINARY): put fd in binary mode if it is not a > console on EMX. A changelog entry should usually specify the difference between the previous behaviour and the new behaviour. Therefore here it should better read: * lib/binary-io.h (SET_BINARY): Don't put fd in binary mode