Re: [PATCH] tests/test-strstr.c: Add another self-test.

2009-05-26 Thread Eric Blake
Bruno Haible clisp.org> writes: > > Eric Blake wrote: > > http://www.alphalinux.org/archives/axp-list/March2001/0337.shtml > > > > It looks like the bug is alpha-specific in memchr > > I don't think it is a bug. memchr could also be implemented by doing > a backwards search and still be confor

Re: [PATCH] tests/test-strstr.c: Add another self-test.

2009-05-26 Thread Bruno Haible
Eric Blake wrote: > http://www.alphalinux.org/archives/axp-list/March2001/0337.shtml > > It looks like the bug is alpha-specific in memchr I don't think it is a bug. memchr could also be implemented by doing a backwards search and still be conforming to ISO C99 and POSIX: void *memchr(const vo

Re: [PATCH] tests/test-strstr.c: Add another self-test.

2009-05-26 Thread Simon Josefsson
Eric Blake writes: > According to Simon Josefsson on 5/26/2009 6:15 AM: >> +2009-05-26 Simon Josefsson >> + >> +* tests/test-strstr.c: Add another self-test. >>{ >> +/* See http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=521737 */ >> +char *input = strdup ("aBaaax"); >

Re: [PATCH] tests/test-strstr.c: Add another self-test.

2009-05-26 Thread Simon Josefsson
Eric Blake writes: > According to Simon Josefsson on 5/26/2009 6:48 AM: >> I'm not sure, it isn't clear that this particular strstr problem is a >> common problem. >> >> I think the first step is to add this to the self-test. If we get >> reports about it, we can try to learn which platforms an

Re: [PATCH] tests/test-strstr.c: Add another self-test.

2009-05-26 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Eric Blake on 5/26/2009 6:56 AM: > Yes, adding to the test is a good first step, and we can use the feedback > to decide how much else we might need to do. Is the bug also present in > gnulib's strstr replacement? To answer my own questi

Re: [PATCH] tests/test-strstr.c: Add another self-test.

2009-05-26 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Simon Josefsson on 5/26/2009 6:15 AM: > +2009-05-26 Simon Josefsson > + > + * tests/test-strstr.c: Add another self-test. >{ > +/* See http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=521737 */ > +char *input = strdup ("

Re: [PATCH] tests/test-strstr.c: Add another self-test.

2009-05-26 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Simon Josefsson on 5/26/2009 6:48 AM: > I'm not sure, it isn't clear that this particular strstr problem is a > common problem. > > I think the first step is to add this to the self-test. If we get > reports about it, we can try to learn

Re: [PATCH] tests/test-strstr.c: Add another self-test.

2009-05-26 Thread Simon Josefsson
Eric Blake writes: > According to Simon Josefsson on 5/26/2009 6:15 AM: >>{ >> +/* See http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=521737 */ >> +char *input = strdup ("aBaaax"); >> +const char *result = strstr (input, "B1x"); > > Does this mean we also need to beef up

Re: [PATCH] tests/test-strstr.c: Add another self-test.

2009-05-26 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Simon Josefsson on 5/26/2009 6:15 AM: >{ > +/* See http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=521737 */ > +char *input = strdup ("aBaaax"); > +const char *result = strstr (input, "B1x"); Does this mean we als