Re: [PATCH] test-parse-datetime.c: accommodate a relatively strict gcc warning

2011-08-31 Thread Jim Meyering
Eric Blake wrote: > On 08/31/2011 08:44 AM, Jim Meyering wrote: >> @@ -93,21 +93,21 @@ tm_diff (struct tm const *a, struct tm const *b) >> } >> #endif /* ! HAVE_TM_GMTOFF */ >> >> -long >> -gmt_offset() >> +static long >> +gmt_offset () > > Shouldn't this be: > > static long > gmt_offset (void

Re: [PATCH] test-parse-datetime.c: accommodate a relatively strict gcc warning

2011-08-31 Thread Eric Blake
On 08/31/2011 08:44 AM, Jim Meyering wrote: @@ -93,21 +93,21 @@ tm_diff (struct tm const *a, struct tm const *b) } #endif /* ! HAVE_TM_GMTOFF */ -long -gmt_offset() +static long +gmt_offset () Shouldn't this be: static long gmt_offset (void) to avoid yet more warnings about K&R declarati