Re: [PATCH] string, wchar: avoid some namespace pollution

2022-01-04 Thread Bruno Haible
Paul Eggert did this on 2021-09-07: > * lib/string.in.h, lib/wchar.in.h: > (free): Declare by hand instead of including stdlib.h. > This avoids some namespace pollution. Unfortunately, when compiling GNU libiconv (or GNU libunistring) with MSVC, it causes this compilation error: /home/bruno/msvc/

Re: [PATCH] string, wchar: avoid some namespace pollution

2021-09-23 Thread Simon Josefsson via Gnulib discussion list
Bruno Haible writes: > Thanks for the heads-up, Simon. I debugged it, and indeed the cause is > in gnulib, not in libidn. The patch below fixes it. Thanks for debugging this Bruno! /Simon signature.asc Description: PGP signature

Re: [PATCH] string, wchar: avoid some namespace pollution

2021-09-18 Thread Bruno Haible
Paul Eggert did on 2021-09-07: > diff --git a/lib/string.in.h b/lib/string.in.h > index fa2e40c25..6214b5578 100644 > --- a/lib/string.in.h > +++ b/lib/string.in.h > @@ -47,9 +47,6 @@ > /* NetBSD 5.0 mis-defines NULL. */ > #include > > -/* Get free(). */ > -#include > - > /* MirBSD defines

Re: [PATCH] string, wchar: avoid some namespace pollution

2021-09-08 Thread Bruno Haible
Oops, apologies, Paul. Your patch _does_ look correct. (I should have read the entire patch, not just the ChangeLog entry.) Bruno

Re: [PATCH] string, wchar: avoid some namespace pollution

2021-09-08 Thread Bruno Haible
Hi Paul, > * lib/string.in.h, lib/wchar.in.h: > (free): Declare by hand instead of including stdlib.h. This does not look right to me. There are two cases: (A) REPLACE_FREE is 0. Then it is OK to declare it by hand, because gnulib uses the system's free() function. (B) REPLACE_FREE is 1. (T