Re: [PATCH] stdio: fix probe on mingw under gcc 5.1

2015-05-26 Thread Eric Blake
On 05/26/2015 04:09 PM, Assaf Gordon wrote: > Hello Eric, > > Thanks for your quick reply and fix. > > I've found one more issue which I'm not sure how to solve - interplay > between gcc/mingw/inttypes/gnulib: The format string to "error()". > > In theory (if I understand correctly), printf() an

Re: [PATCH] stdio: fix probe on mingw under gcc 5.1

2015-05-26 Thread Assaf Gordon
Hello Eric, Thanks for your quick reply and fix. I've found one more issue which I'm not sure how to solve - interplay between gcc/mingw/inttypes/gnulib: The format string to "error()". In theory (if I understand correctly), printf() and error() should accept the same format specifiers, thus

Re: [PATCH] stdio: fix probe on mingw under gcc 5.1

2015-05-26 Thread Eric Blake
On 05/26/2015 02:21 PM, Eric Blake wrote: > On 05/26/2015 01:49 PM, Assaf Gordon wrote: >> Hello, >> >> I'm encountering a similar/related issue with PRIdMAX on mingw32-gcc 4.8.2. >> > > Okay, so that's a version of mingw new enough to honor > __USE_MINGW_ANSI_STDIO, and a version of gcc old enou

Re: [PATCH] stdio: fix probe on mingw under gcc 5.1

2015-05-26 Thread Eric Blake
On 05/26/2015 01:49 PM, Assaf Gordon wrote: > Hello, > > I'm encountering a similar/related issue with PRIdMAX on mingw32-gcc 4.8.2. > > In short, when using gnulib in my project and cross-compiling with > mingw32-gcc 4.8.2 > somehow the PRIdMAX becomes "lld" instead of "I64d". That somehow is t

Re: [PATCH] stdio: fix probe on mingw under gcc 5.1

2015-05-26 Thread Assaf Gordon
Hello, I'm encountering a similar/related issue with PRIdMAX on mingw32-gcc 4.8.2. In short, when using gnulib in my project and cross-compiling with mingw32-gcc 4.8.2 somehow the PRIdMAX becomes "lld" instead of "I64d". I was able to reproduce it with GNU Hello (long details below). perhaps

Re: [PATCH] stdio: fix probe on mingw under gcc 5.1

2015-05-22 Thread Eric Blake
On 05/20/2015 11:01 PM, Paul Eggert wrote: > Eric Blake wrote: >> I'm still open to any cleaner test, easy enough to maintain. > > All we care about is (1) is it MingW and (2) has it defined PRIdMAX to > be "lld" or to be "I64d". Is that right? If so, the first we can tell > via inspecting a pre

Re: [PATCH] stdio: fix probe on mingw under gcc 5.1

2015-05-20 Thread Paul Eggert
Eric Blake wrote: I'm still open to any cleaner test, easy enough to maintain. All we care about is (1) is it MingW and (2) has it defined PRIdMAX to be "lld" or to be "I64d". Is that right? If so, the first we can tell via inspecting a predefined preprocessor macro, and the second we can t

Re: [PATCH] stdio: fix probe on mingw under gcc 5.1

2015-05-20 Thread Eric Blake
On 05/20/2015 09:40 PM, Paul Eggert wrote: > $EGREP has undefined behavior on binary data, so this isn't portable. Bummer. It will work on mingw (which only uses GNU grep), which is the affected platform, but you're right that we have to make it not break other platforms. And 'strings' is not po

Re: [PATCH] stdio: fix probe on mingw under gcc 5.1

2015-05-20 Thread Paul Eggert
$EGREP has undefined behavior on binary data, so this isn't portable. I long ago gave up on AC_EGREP_CPP, since it's too flaky nowadays. Why can't we test directly for what we're worried about? I'm afraid I am not following why the value of PRIdMAX is related to whether printf should use the

Re: [PATCH] stdio: fix probe on mingw under gcc 5.1

2015-05-20 Thread Pádraig Brady
On 21/05/15 00:26, Eric Blake wrote: > Per https://gcc.gnu.org/gcc-5/porting_to.html, gcc 5.1 intentionally > changed the preprocessor to emit multiple lines, rather than one > line, when expanding text that includes literal markers combined with > a macro expansion obtained from a header. This in