Re: [PATCH] regex: trim module dependencies

2018-07-01 Thread Paul Eggert
Thanks for the detailed review, and you're right on all counts. I installed the attached to do the fixes you suggest. I'm still having trouble with the regex code under Emacs, and will try to follow up shortly. >From e09e64c7e0d3c9d0cca82cb80713f8aea195d493 Mon Sep 17 00:00:00 2001 From: Paul E

Re: [PATCH] regex: trim module dependencies

2018-07-01 Thread Bruno Haible
Hi Paul, > * modules/regex (Depends-on): Remove gettext-h and lock, > since the regex code should work OK without these modules, > and Emacs uses it that way. The removal of the gettext-h dependency is fine; regex_internal.h tests ENABLE_NLS and includes . But I object against the removal of the