Re: [PATCH] mkdir-p: Don't discard stat error

2018-12-16 Thread Niklas Hambüchen
On 15/12/2018 1:27 AM, Paul Eggert wrote: + if (stat (dir + prefix_len, &st) == 0 + && S_ISDIR (st.st_mode)) That patch doesn't look quite right, since it can use errno even when stat succeeded (in which case errno contains garbage). Oops, you're right,

Re: [PATCH] mkdir-p: Don't discard stat error

2018-12-14 Thread Paul Eggert
On 12/14/18 1:10 PM, Niklas Hambüchen wrote: + if (stat (dir + prefix_len, &st) == 0 + && S_ISDIR (st.st_mode)) +return true; + else +{ + error (0, errno, +