Re: [PATCH] gnulib-tool.py: Follow gnulib-tool changes, part 51.

2024-03-11 Thread Collin Funk
Hi Bruno, On 3/11/24 4:32 AM, Bruno Haible wrote: > Another GNU package in the same realm is GNU Bison. If you like regular > expression and automata theory, you will like GNU Bison as well. Thanks for the suggestion. I've never gotten around to using YACC or GNU Bison, surprisingly. I'll find so

Re: [PATCH] gnulib-tool.py: Follow gnulib-tool changes, part 51.

2024-03-11 Thread Bruno Haible
Hi Collin, > The POSIX BRE vs. ERE along with backreferences, assertions, lazy vs. > greedy matching allowed by some languages adds multiple layers of > complexity which starts to hurt my brain. :) Yes, the many variants of regular expressions are complicated... > The DFA module also looks prett

Re: [PATCH] gnulib-tool.py: Follow gnulib-tool changes, part 51.

2024-03-10 Thread Collin Funk
Hi Bruno, On 3/10/24 3:51 PM, Bruno Haible wrote: > I prefer comparing with '' explicitly. It's clearer about the intent. > It avoids an implicit conversion from str to bool. Sure, makes sense. I'll keep that in mind in the future. > Regarding the regex change: In a group '(...)' one needs to us

Re: [PATCH] gnulib-tool.py: Follow gnulib-tool changes, part 51.

2024-03-10 Thread Bruno Haible
Hi Collin, > Hopefully this patch should be better. Thanks, much better. I applied it, together with this follow-up: 2024-03-10 Bruno Haible gnulib-tool.py: Tweak last commit. * pygnulib/GLEmiter.py (GLEmiter.initmacro_end): Avoid an implicit str to bool conversion.

Re: [PATCH] gnulib-tool.py: Follow gnulib-tool changes, part 51.

2024-03-10 Thread Collin Funk
Hi Bruno, Hopefully this patch should be better. Feel free to let me know if there is anything I didn't address. On 3/10/24 5:07 AM, Bruno Haible wrote: > 1) This form of conditional expression > >base = self.config['destdir'] if self.config['destdir'] else '.' > >mentions first a v

Re: [PATCH] gnulib-tool.py: Follow gnulib-tool changes, part 51.

2024-03-10 Thread Bruno Haible
Hi Collin, > I've implemented the initial support for --automake-subdir in > gnulib-tool.py. It is a larger patch so let me know if you have any > questions. Thanks. Though, it would be nice to improve a couple of things: 1) This form of conditional expression base = self.config['destdi