Re: [PATCH] gnulib-tool.py: Follow gnulib-tool changes, part 40.

2024-03-05 Thread Bruno Haible
Collin Funk wrote: > Here is a simple patch that fixes the conditionals when using > --gnu-make. Thanks, applied. Bruno

Re: [PATCH] gnulib-tool.py: Follow gnulib-tool changes, part 40.

2024-03-05 Thread Bruno Haible
Oops, these comments of mine apply to part 41, not part 40! > Thanks, but there's a difference here: > In gnulib-tool the condition was > > if test "${var}" = SUBDIRS && test -n "$dotfirst"; then > > whereas in your patch, in pygnulib/GLEmiter.py lines 804 and 1108, I see > >

Re: [PATCH] gnulib-tool.py: Follow gnulib-tool changes, part 40.

2024-03-05 Thread Bruno Haible
Collin Funk wrote: > While working on another item in the TODO, I think I found a mistake > but it is hard for me to tell from diff'ing the output at the moment. > > I think the two lines I've linked are referring to the same thing. > ... > Shouldn't the Python one be using 'self.emitter.tests_Mak

Re: [PATCH] gnulib-tool.py: Follow gnulib-tool changes, part 40.

2024-03-05 Thread Bruno Haible
Collin Funk wrote: > Here is a simple patch that fixes the conditionals when using > --gnu-make. It should be pretty easy to test with the Emacs script if > you would like to double check. Thanks, but there's a difference here: In gnulib-tool the condition was if test "${var}" = SUBDIRS &