Re: [PATCH] gnulib-tool.py: Follow gnulib-tool changes, part 39.

2024-03-04 Thread Bruno Haible
Hi Collin, > The error should only be removed in mode == 'import' correct? Yes. Patch applied. Thanks! Bruno

Re: [PATCH] gnulib-tool.py: Follow gnulib-tool changes, part 39.

2024-03-04 Thread Collin Funk
Hi Bruno, On 3/3/24 4:30 AM, Bruno Haible wrote: > In the original commit, I removed the error message > "option --conditional-dependencies is not supported with --with-tests" > only at one place (the command-line option checks), but left it in > func_import. > You are removing it in both places

Re: [PATCH] gnulib-tool.py: Follow gnulib-tool changes, part 39.

2024-03-03 Thread Collin Funk
On 3/3/24 4:30 AM, Pádraig Brady wrote: > Right, join without options is essentially set intersection. > See https://www.pixelbeat.org/cmdline.html#sets Thanks for the examples. Bookmarked it since it will probably come handy as I work on gnulib-tool. :) Collin

Re: [PATCH] gnulib-tool.py: Follow gnulib-tool changes, part 39.

2024-03-03 Thread Collin Funk
On 3/3/24 4:30 AM, Bruno Haible wrote: > In the original commit, I removed the error message > "option --conditional-dependencies is not supported with --with-tests" > only at one place (the command-line option checks), but left it in > func_import. > You are removing it in both places (mode == 'i

Re: [PATCH] gnulib-tool.py: Follow gnulib-tool changes, part 39.

2024-03-03 Thread Bruno Haible
Hello Collin, > -for m in $modules; do echo $m; done | LC_ALL=C sort -u > "$tmp"/modules > +for m in $referenceable_modules; do echo $m; done | LC_ALL=C sort -u > > "$tmp"/modules > > Which I didn't understand until seeing this line [1]: > > deps=`for m in $deps; do echo $m; done | LC_A

Re: [PATCH] gnulib-tool.py: Follow gnulib-tool changes, part 39.

2024-03-03 Thread Pádraig Brady
On 03/03/2024 05:33, Collin Funk wrote: On 3/2/24 7:02 PM, Collin Funk wrote: When working on the one of the TODO entries I noticed that the gnulib-comp.m4 output was incorrect. Here is the item I was working on. I _think_ I understood it correctly but you guys are much more talented at shell