Thanks -- I agree avoiding 'grep' is nice, I pushed this change inspired
by your approach.
/Simon
From 83c5387249b5bbfd32d01a51af14ac53bac1bc36 Mon Sep 17 00:00:00 2001
From: Simon Josefsson
Date: Sat, 28 Dec 2024 21:19:18 +0100
Subject: [PATCH] git-version-gen: avoid use of grep, suggested by Ji
On Sat, Dec 28, 2024 at 11:26 AM Simon Josefsson wrote:
>
> Jim Meyering writes:
>
> > On Sat, Dec 28, 2024 at 10:01 AM Simon Josefsson
> > wrote:
> >> Jim Meyering writes:
> >>
> >> >> if test "x$v" = xUNKNOWN \
> >> >> && test -f ${tarball_version_file}-git \
> >> >> && head
Jim Meyering writes:
> On Sat, Dec 28, 2024 at 10:01 AM Simon Josefsson wrote:
>> Jim Meyering writes:
>>
>> >> if test "x$v" = xUNKNOWN \
>> >> && test -f ${tarball_version_file}-git \
>> >> && head -1 ${tarball_version_file}-git \
>> >> | grep -v '^$Format' > /dev/
On Sat, Dec 28, 2024 at 10:01 AM Simon Josefsson wrote:
> Jim Meyering writes:
>
> >> if test "x$v" = xUNKNOWN \
> >> && test -f ${tarball_version_file}-git \
> >> && head -1 ${tarball_version_file}-git \
> >> | grep -v '^$Format' > /dev/null 2>&1; then
> >> v=$(he
Simon Josefsson via Gnulib discussion list writes:
> --- a/top/maint.mk
> +++ b/top/maint.mk
Please disregard that part, it is an unrelated the change for a
completely different problem and I'm still experimenting with that patch
to see if it is the right one...
/Simon
signature.asc
Descripti
Jim Meyering writes:
>> if test "x$v" = xUNKNOWN \
>> && test -f ${tarball_version_file}-git \
>> && head -1 ${tarball_version_file}-git \
>> | grep -v '^$Format' > /dev/null 2>&1; then
>> v=$(head -1 ${tarball_version_file}-git)
>> fi
>
> That code uses "grep -v"
Oops. Thank you.
Hmm... it shouldn't be hard to make vc-dwim do the right thing by
default for projects like gnulib that VC their ChangeLog file.
On Sat, Dec 28, 2024 at 9:46 AM Bruno Haible wrote:
>
> Jim Meyering wrote:
> > I've fixed that and cleaned up via this just-pushed change:
>
> I've a
Jim Meyering wrote:
> I've fixed that and cleaned up via this just-pushed change:
I've added the mandatory ChangeLog entry for your change.
Bruno
On Fri, Dec 27, 2024 at 3:35 AM Simon Josefsson wrote:
> Hi Jim, all,
Hi Simon,
> If I run git-version-gen in a snapshot of a git repository it will
> return UNKNOWN because it cannot find out the version.
>
> Git has a .gitattribute mechanism to mark some files as 'export-subst'
> which makes g
Bruno Haible via Gnulib discussion list writes:
> Hi Simon,
>
> Would you mind adding a ChangeLog entry for this commit?
Sorry about that, fixed now!
/Simon
signature.asc
Description: PGP signature
Hi Simon,
Would you mind adding a ChangeLog entry for this commit?
Bruno
11 matches
Mail list logo
