Re: [PATCH] chdir-long: avoid -Werror=unused-variable with -DNDEBUG

2014-12-20 Thread Norihiro Tanaka
On Sat, 20 Dec 2014 18:20:06 -0800 Paul Eggert wrote: > I'd rather not, as the idea is not gnulib-specific. Thanks, I understood.

Re: [PATCH] chdir-long: avoid -Werror=unused-variable with -DNDEBUG

2014-12-20 Thread Paul Eggert
Norihiro Tanaka wrote: how about "gl_assert" instead of "assure"? I'd rather not, as the idea is not gnulib-specific.

Re: [PATCH] chdir-long: avoid -Werror=unused-variable with -DNDEBUG

2014-12-20 Thread Norihiro Tanaka
On Sat, 20 Dec 2014 13:03:23 -0800 Paul Eggert wrote: > That sort of thing looks like it'd be reasonably annoying in the long > run. How about the attached patch instead? I confirmed that it had already been committed. Thanks.

Re: [PATCH] chdir-long: avoid -Werror=unused-variable with -DNDEBUG

2014-12-20 Thread Norihiro Tanaka
On Sat, 20 Dec 2014 13:03:23 -0800 Paul Eggert wrote: > Norihiro Tanaka wrote: > > +#if NDEBUG > > + close (cdb->fd); > > +#else > > bool close_fail = close (cdb->fd); > > assert (! close_fail); > > +#endif > > That sort of thing looks like it'd be reasonably annoying in the

Re: [PATCH] chdir-long: avoid -Werror=unused-variable with -DNDEBUG

2014-12-20 Thread Paul Eggert
Norihiro Tanaka wrote: +#if NDEBUG + close (cdb->fd); +#else bool close_fail = close (cdb->fd); assert (! close_fail); +#endif That sort of thing looks like it'd be reasonably annoying in the long run. How about the attached patch instead? >From 972fd2a46979d17458eb900235