Re: [PATCH] argv-iter: new module

2009-07-05 Thread Jim Meyering
Bruno Haible wrote: > Hi Jim, > > For a module that is to be used by several package, some more documentation > is needed IMO. From the comments outside of functions that are present, I can > only get a vague impression that the module is about "Iterate over arguments > from argv or --files0-from=F

Re: [PATCH] argv-iter: new module

2009-07-05 Thread James Youngman
On Sun, Jul 5, 2009 at 11:19 AM, Bruno Haible wrote: > About the unit test: > >> +#define STREQ(s1, s2) ((strcmp (s1, s2) == 0)) > > What is the reason for the extra parentheses? Is some gcc warning avoided > by this? Well, that technique does protect you against bugs resulting from various odd us

Re: [PATCH] argv-iter: new module

2009-07-05 Thread Bruno Haible
Hi Jim, For a module that is to be used by several package, some more documentation is needed IMO. From the comments outside of functions that are present, I can only get a vague impression that the module is about "Iterate over arguments from argv or --files0-from=FILE" and that file has is suppo