Re: [PATCH] Do not limit git-version-gen to work only under the repository root.

2010-10-13 Thread Giuseppe Scrivano
Hello Jim, Jim Meyering writes: > Thanks again for the quick corrections. > Here's a better version. I'll wait for review this time ;-) I have tried the new version and it seems to work well. I am going to remove the workaround I had to use and keep my copy sync'ed with the gnulib version.

Re: [PATCH] Do not limit git-version-gen to work only under the repository root.

2010-10-13 Thread Jim Meyering
Jim Meyering wrote: > Giuseppe Scrivano wrote: > >> Hello, >> >> Jim Meyering writes: >> >>> Not sure about more "elegant", but here's a lower cost method: >> >> Thanks for the patch but I think the problem you have reported here: >> >> http://article.gmane.org/gmane.comp.lib.gnulib.bugs/21845

Re: [PATCH] Do not limit git-version-gen to work only under the repository root.

2010-10-13 Thread Jim Meyering
Giuseppe Scrivano wrote: > Hello, > > Jim Meyering writes: > >> Not sure about more "elegant", but here's a lower cost method: > > Thanks for the patch but I think the problem you have reported here: > > http://article.gmane.org/gmane.comp.lib.gnulib.bugs/21845 > > persists. > > > Here an examp

Re: [PATCH] Do not limit git-version-gen to work only under the repository root.

2010-10-13 Thread Giuseppe Scrivano
Hello, Jim Meyering writes: > Not sure about more "elegant", but here's a lower cost method: Thanks for the patch but I think the problem you have reported here: http://article.gmane.org/gmane.comp.lib.gnulib.bugs/21845 persists. Here an example, where /tmp/foo is a git repository. /tmp/

Re: [PATCH] Do not limit git-version-gen to work only under the repository root.

2010-10-13 Thread Jim Meyering
Giuseppe Scrivano wrote: > Bruno, Jim, > > thanks for your comments. > > > Jim Meyering writes: > >> What is your use case? > > I have the git repository in myserver/, but the top_srcdir is in > myserver/myserver/. > > >> Won't this proposal cause trouble when >> running git-version-gen in a non-

Re: [PATCH] Do not limit git-version-gen to work only under the repository root.

2010-05-10 Thread Giuseppe Scrivano
Bruno, Jim, thanks for your comments. Jim Meyering writes: > What is your use case? I have the git repository in myserver/, but the top_srcdir is in myserver/myserver/. > Won't this proposal cause trouble when > running git-version-gen in a non-version-controlled > pkg-top-level-directory t

Re: [PATCH] Do not limit git-version-gen to work only under the repository root.

2010-05-10 Thread Jim Meyering
Giuseppe Scrivano wrote: > I would like to use git-version-gen from a directory that is not the > repository root, so "test -d .git" is not the proper check. > > What about this patch? Hi Giuseppe, What is your use case? Won't this proposal cause trouble when running git-version-gen in a non-ver

Re: [PATCH] Do not limit git-version-gen to work only under the repository root.

2010-05-10 Thread Bruno Haible
Hello Giuseppe, > +elif git describe > /dev/null 2>&1 \ If 'git' is not found in PATH, this line would yield an error message in some shells. To avoid that, run the command in a sub-shell: elif (git describe) > /dev/null 2>&1 \ > * build-aux/git-version-gen: Check if it is a git repository usi