Re: [PATCH] Add an implementation of gnulib's canonicalize_file_name for mingw.

2011-02-01 Thread Bruno Haible
Hello Jan, > > In which respect did you find it useless for mingw? > > In that, when given an absolute file name, such as > >c:/program files/lilypond/usr/share/guile/2.0/ice-9/boot-9.scm > > it returns NULL. This is indeed useless and needs to be improved. > It also returns NULL when giv

Re: [PATCH] Add an implementation of gnulib's canonicalize_file_name for mingw.

2011-02-01 Thread Eric Blake
On 02/01/2011 06:59 AM, Jan Nieuwenhuizen wrote: > It's good to see how thorough you are, even though I still think > this is not much of a change as much as a first implementation. > > See attached, greetings, > Bruno Haible schreef op di 01-02-2011 om 10:46 [+0100]: > > Hi Bruno, > >> > In wh

Re: [PATCH] Add an implementation of gnulib's canonicalize_file_name for mingw.

2011-02-01 Thread Jan Nieuwenhuizen
Bruno Haible schreef op di 01-02-2011 om 10:46 [+0100]: Hi Bruno, > In which respect did you find it useless for mingw? In that, when given an absolute file name, such as c:/program files/lilypond/usr/share/guile/2.0/ice-9/boot-9.scm it returns NULL. It also returns NULL when given the CWD

Re: [PATCH] Add an implementation of gnulib's canonicalize_file_name for mingw.

2011-02-01 Thread Bruno Haible
Hi, Jan Nieuwenhuizen wrote: > Attached is a patch that fixes canonicalize_file_name for mingw. > ... > The original is useless for mingw In which respect did you find it useless for mingw? We have a unit test for this module (tests/test-canonicalize-lgpl.c). I occasionally run it on mingw, and