Re: [Grep-devel] [PATCH] dfa: fix performance bug that recomputes trans

2016-12-10 Thread Paul Eggert
Jim Meyering wrote: Do you have an example (preferably pathological) that demonstrates a significant performance difference? I'm afraid not. I noticed the issue while debugging Bug#22357 but that's about a quite-different problem.

Re: [Grep-devel] [PATCH] dfa: fix performance bug that recomputes trans

2016-12-09 Thread Jim Meyering
On Fri, Dec 9, 2016 at 3:11 PM, Paul Eggert wrote: > * lib/dfa.c (build_state): Fix performance bug introduced in Nov > 25 on-demand changes. The bug caused build_state to reset all > d->trans elements to -2 even when d->trans was already non-null. > Use C99 style decls after statements in this f